Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/searx: declarative configuration #101849

Merged
merged 7 commits into from Jan 11, 2021
Merged

nixos/searx: declarative configuration #101849

merged 7 commits into from Jan 11, 2021

Conversation

@rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Oct 27, 2020

Motivation for this change

The pain of having to manually diff the settings.yml on every update,
like if NixOS were some kind of Arch Linux.

Things done
  • Tested environment substitution
  • Tested configuration merging
  • Tested service runs
  • Remove searx uid,gids
  • Document changes in the release notes
  • Run more tests for uWSGI
  • Figure out why immediate-uid is necessary
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@rnhmjoj
Copy link
Contributor Author

@rnhmjoj rnhmjoj commented Nov 2, 2020

I managed to get the right merging behavior by making engines an attrset and casting some jq spells.
Also added a test and documentation.

@rnhmjoj
Copy link
Contributor Author

@rnhmjoj rnhmjoj commented Nov 7, 2020

I went down a rabbit hole trying to run searx in uWSGI but I finally did it.
This is a must because searx runs in werkzeug by default: it logs every request (including search keywords!) and there is no way to disable logging unless one changes the webserver, of course.

@rnhmjoj rnhmjoj requested a review from LnL7 Nov 7, 2020
@rnhmjoj
Copy link
Contributor Author

@rnhmjoj rnhmjoj commented Nov 7, 2020

The PR got so big, maybe uWSGI changes should be split out.

@rnhmjoj
Copy link
Contributor Author

@rnhmjoj rnhmjoj commented Nov 13, 2020

Fixed a couple more issues with uWSGI.

@rnhmjoj
Copy link
Contributor Author

@rnhmjoj rnhmjoj commented Dec 6, 2020

For easier review, I've opened a PR with only the uwsgi changes: #106082

@rnhmjoj
Copy link
Contributor Author

@rnhmjoj rnhmjoj commented Jan 10, 2021

Rebased. Now that the uWSGI changes have been accepted this builds in master.

@rnhmjoj rnhmjoj merged commit b1fb65a into NixOS:master Jan 11, 2021
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment