Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matrix-synapse: 1.21.2 -> 1.22.0 #101853

Merged
merged 2 commits into from Oct 28, 2020
Merged

matrix-synapse: 1.21.2 -> 1.22.0 #101853

merged 2 commits into from Oct 28, 2020

Conversation

@Ma27
Copy link
Member

@Ma27 Ma27 commented Oct 27, 2020

Motivation for this change

https://github.com/matrix-org/synapse/releases/tag/v1.22.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
fadenb
fadenb approved these changes Oct 27, 2020
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Builds on darwin with #101319 merged.

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 27, 2020

Result of nixpkgs-review pr 101853 1

1 package built:
  • matrix-synapse

Ekleog
Ekleog approved these changes Oct 28, 2020
Copy link
Member

@Ekleog Ekleog left a comment

LGTM, just had a comment about potential improvements for the optional dependency but IMO this is good enough to land as is if you don't feel like doing it now

pkgs/servers/matrix-synapse/default.nix Outdated Show resolved Hide resolved
This is only needed for replication which isn't even supported by the
current NixOS module.
@Ma27 Ma27 requested review from Ekleog and mweinelt Oct 28, 2020
@ofborg ofborg bot requested a review from fadenb Oct 28, 2020
fadenb
fadenb approved these changes Oct 28, 2020
@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 28, 2020

Result of nixpkgs-review pr 101853 1

1 package built:
  • matrix-synapse

@mweinelt mweinelt merged commit 41f0c4a into NixOS:master Oct 28, 2020
19 of 20 checks passed
@Ma27 Ma27 deleted the bump-matrix-synapse branch Oct 28, 2020
@Ma27
Copy link
Member Author

@Ma27 Ma27 commented Oct 28, 2020

@mweinelt do you also take care of the backport? %)

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 28, 2020

Feel free to do it, I'm busy with #101968 right now.

@Ma27
Copy link
Member Author

@Ma27 Ma27 commented Oct 28, 2020

20.03: e39c1f4, 504f993
20.09: bf86311, 86777b5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment