Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/cabal-install: init #101860

Closed
wants to merge 1 commit into from
Closed

Conversation

@xaverdh
Copy link
Contributor

@xaverdh xaverdh commented Oct 27, 2020

Motivation for this change

cf. #85136

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Will add some docs if / when people agree, that this is a good approach.

@xaverdh xaverdh force-pushed the cabal-install-module branch from 0e5c843 to c43c3ac Oct 28, 2020
@xaverdh
Copy link
Contributor Author

@xaverdh xaverdh commented Feb 6, 2021

closing, since this was resolved in 643169b

@xaverdh xaverdh closed this Feb 6, 2021
@xaverdh xaverdh deleted the cabal-install-module branch Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant