Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wine{Unstable,Staging}: 5.18 -> 5.20 #101862

Merged
merged 2 commits into from Oct 28, 2020
Merged

wine{Unstable,Staging}: 5.18 -> 5.20 #101862

merged 2 commits into from Oct 28, 2020

Conversation

@SFrijters
Copy link
Member

@SFrijters SFrijters commented Oct 27, 2020

Motivation for this change

Upstream updates, seems to include some nice esync related stuff again.

$ nix-shell -p nixpkgs-review --run "nixpkgs-review rev wine-5.20"
[...]
9 package built:
lutris lutris-free lutris-unwrapped pipelight wineStaging winePackages.staging wineUnstable wineWowPackages.staging wineWowPackages.unstable

The intermediate 5.19 has been nixpkgs-reviewed as well without issues.

The programs I run under wine seem to work fine with this new version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
veprbl
veprbl approved these changes Oct 28, 2020
Copy link
Member

@veprbl veprbl left a comment

LGTM

@veprbl veprbl merged commit 4e3cc04 into NixOS:master Oct 28, 2020
17 checks passed
@SFrijters SFrijters deleted the wine-5.20 branch Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants