Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groff: fix PDF manpage building with -Tpdf/gropdf #101866

Merged
merged 1 commit into from Nov 22, 2020
Merged

Conversation

@catern
Copy link
Contributor

@catern catern commented Oct 27, 2020

These files are pure data, just fonts; they shouldn't have been moved
to the "perl" output, because the Perl programs (namely, gropdf) use
them from the main "out" output.

These files don't contain any references to more dependencies (Perl or
otherwise), so they don't bloat the closure. And the files themselves
are small; 276K total as of this commit.

These files are pure data, just fonts; they shouldn't have been moved
to the "perl" output, because the Perl programs (namely, gropdf) use
them from the main "out" output.

These files don't contain any references to more dependencies (Perl or
otherwise), so they don't bloat the closure. And the files themselves
are small; 276K total as of this commit.
@ofborg ofborg bot requested a review from pSub Oct 27, 2020
@7c6f434c 7c6f434c merged commit 5c4a215 into NixOS:master Nov 22, 2020
19 checks passed
@cirno-999
Copy link

@cirno-999 cirno-999 commented Nov 26, 2020

I've had this issue; I've tried to build groff with this patch locally to fix it, but it seems like there's no www.tmac in the tarball? (substitute(): ERROR: file 'tmac/www.tmac' does not exist) Changed it to www.tmac.in, seems to build.

@catern
Copy link
Contributor Author

@catern catern commented Nov 29, 2020

@cirno-999 That's the build error you get from running nix-build? Did you make some other local change? Maybe you updated to a new version? It builds fine for me, and this has been in master for a week now so it seems to build fine for everyone.

@cirno-999
Copy link

@cirno-999 cirno-999 commented Nov 29, 2020

@cirno-999 That's the build error you get from running nix-build? Did you make some other local change? Maybe you updated to a new version? It builds fine for me, and this has been in master for a week now so it seems to build fine for everyone.

You could say I made a local change, I defined my own package from the source
I suspect that is because I bypassed the cache, and the nixpkgs groff .tar.gz is cached, but has been changed recently

@catern
Copy link
Contributor Author

@catern catern commented Nov 29, 2020

I'm guessing, from the error message, that you're building directly from groff's git repo and not a groff release tarball. That won't work in general; tarballs are not necessarily the same as what's in git. (For example, you might need to run autoreconf -i to generate some additional files when building from git; there's autoreconfHook in Nixpkgs which automates this if you add it to buildInputs.)

Anyway, that seems unrelated to this issue.

@cirno-999
Copy link

@cirno-999 cirno-999 commented Nov 29, 2020

I'm guessing, from the error message, that you're building directly from groff's git repo and not a groff release tarball. That won't work in general; tarballs are not necessarily the same as what's in git. (For example, you might need to run autoreconf -i to generate some additional files when building from git; there's autoreconfHook in Nixpkgs which automates this if you add it to buildInputs.)

Anyway, that seems unrelated to this issue.

no, I'm building from tarball (but feel free to not continue this discussion if you feel it's not relevant.)

@catern
Copy link
Contributor Author

@catern catern commented Nov 29, 2020

Can you paste the change you made? (Mainly for the URL to the tarball)

@cirno-999
Copy link

@cirno-999 cirno-999 commented Nov 29, 2020

Can you paste the change you made? (Mainly for the URL to the tarball)

my configuration is at https://github.com/cirno-999/berlin
groff is called as mygroff in packages.nix

@catern
Copy link
Contributor Author

@catern catern commented Nov 29, 2020

That appears to be a complete copy and paste of the package. I was more hoping for a diff. You might try using overrideAttrs instead to change just the "src" attribute: https://nixos.org/manual/nixpkgs/stable/#sec-pkg-overrideAttrs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants