Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fasmg: init at j27m #101868

Merged
merged 1 commit into from Nov 26, 2020
Merged

fasmg: init at j27m #101868

merged 1 commit into from Nov 26, 2020

Conversation

@luc65r
Copy link
Contributor

@luc65r luc65r commented Oct 27, 2020

Motivation for this change

Package fasmg to eventually package the CE C Toolchain

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@luc65r luc65r force-pushed the pkg/fasmg branch 2 times, most recently from a901928 to a6dc781 Oct 27, 2020
@luc65r
Copy link
Contributor Author

@luc65r luc65r commented Oct 27, 2020

@orivej I added you as a maintainer because I basically copied your fasm package

@luc65r luc65r force-pushed the pkg/fasmg branch 3 times, most recently from bc8c471 to 8f52004 Oct 28, 2020
@luc65r luc65r force-pushed the pkg/fasmg branch 2 times, most recently from 1c14951 to 7ca4c93 Oct 29, 2020
@luc65r
Copy link
Contributor Author

@luc65r luc65r commented Oct 29, 2020

I changed meta.platforms, I guess fasmg should work for all x86(_64) UNIX

orivej
orivej approved these changes Oct 29, 2020
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 29, 2020

Result of nixpkgs-review pr 101868 run on x86_64-darwin 1

1 package failed to build:
  • fasmg
/nix/store/d61m18vxxwqshv4vik4jw3i7a9d3sflx-stdenv-darwin/setup: line 1310: ./fasmg.x64: cannot execute binary file: Exec format error

Is This binary 64 bit only?

@luc65r
Copy link
Contributor Author

@luc65r luc65r commented Oct 29, 2020

Is This binary 64 bit only?

@SuperSandro2000 ./fasmg is 32 bit, ./fasmg.x64 is 64 bits

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 29, 2020

Is This binary 64 bit only?

@SuperSandro2000 ./fasmg is 32 bit, ./fasmg.x64 is 64 bits

I am not sure how to handle this correctly for 32 and 64 bit machines.

@sikmir Can you help out?

@sikmir
Copy link
Member

@sikmir sikmir commented Oct 29, 2020

@SuperSandro2000 you are trying to build on darwin using linux binary, from readme:

The executable file for Windows is "fasmg.exe", while "fasmg" and "fasmg.x64"
are for Linux in 32-bit and 64-bit format respectively. The files for MacOS
are at "source/macos/fasmg" and "source/macos/x64/fasmg".

@luc65r
Copy link
Contributor Author

@luc65r luc65r commented Oct 29, 2020

@SuperSandro2000 it should work on darwin now

@luc65r
Copy link
Contributor Author

@luc65r luc65r commented Oct 29, 2020

Now I think it can't be more comprehensible (and verbose)

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 29, 2020

Result of nixpkgs-review pr 101868 run on x86_64-darwin 1

1 package built:
  • fasmg

@mkg20001
Copy link
Member

@mkg20001 mkg20001 commented Nov 2, 2020

not sure if pulling binaries is a good idea

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 25, 2020

not sure if pulling binaries is a good idea

If they easily can be build from source this is preferred. @luc65r do you know if this can be done?

@luc65r
Copy link
Contributor Author

@luc65r luc65r commented Nov 25, 2020

This uses the fasmg binary provided in the source to assemble itself. I could try to assemble it with fasm, but IDK if it is possible.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 25, 2020

Result of nixpkgs-review pr 101868 run on x86_64-linux 1

1 package built:
  • fasmg

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 25, 2020

Where did you find the license?

@luc65r
Copy link
Contributor Author

@luc65r luc65r commented Nov 25, 2020

There is a license.txt in the source. I thought it was the same license as fasm, but after reading it, it is definitively BSD3.

@SuperSandro2000 SuperSandro2000 merged commit 27a7098 into NixOS:master Nov 26, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants