Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: 20.09 release notes: remove duplicate service list entry #101871

Merged
merged 1 commit into from Oct 27, 2020

Conversation

@wamserma
Copy link
Contributor

@wamserma wamserma commented Oct 27, 2020

opt-services.foldingathome.enable was listed twice

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
opt-services.foldingathome.enable was listed twice
@wamserma
Copy link
Contributor Author

@wamserma wamserma commented Oct 27, 2020

@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 27, 2020

oops, this probably happened because I just did the vim 41p and skipped over one

@jonringer jonringer merged commit a0cc124 into NixOS:master Oct 27, 2020
17 checks passed
@wamserma wamserma deleted the fix-release-notes branch Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants