Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxima: 5.42.2 -> 5.44.0 #101876

Closed
wants to merge 6 commits into from
Closed

Conversation

@omasanori
Copy link
Contributor

@omasanori omasanori commented Oct 27, 2020

Motivation for this change

This change updates maxima and maxima-ecl packages to the latest release. The change log for Maxima 5.44 and change log for Maxima 5.43 are available.

Note that maxima-ecl now compiles with the default ecl due to failures with Maxima 16.1.2. The sage package, the only remaining client of the ecl_16_1_2 package, will also migrate to ecl in SageMath 9.2.

Depends on #101830.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
omasanori added 6 commits Oct 27, 2020
Since packages are inherited by default, `package ? null` does not work
as a declaration of optional dependency. To solve the problem, I added
`with*` flags and used them consistently.

With this change, the closure size of `maxima` was shrunk from 275429480
bytes to 213117176 bytes (reduced by 22.6%), and that of `maxima-ecl`
was done from 383156392 bytes to 326807728 bytes (reduced by 14.5%).

Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
This makes `patches` easier to read.

Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
Now `maxima-ecl` compiles with the default `ecl` package instead of
`ecl_16_1_2`.

Reference:
https://sourceforge.net/p/maxima/code/ci/master/tree/ChangeLog-5.44.md

Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
@omasanori omasanori changed the title Maxima/update 5.44.0 maxima: 5.42.2 -> 5.44.0 Oct 27, 2020
@ofborg ofborg bot requested a review from peti Oct 27, 2020
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 27, 2020

Run on darwin:

Result of nixpkgs-review pr 101876 1

1 package marked as broken and skipped:
  • maxima-ecl
1 package built:
  • maxima
https://github.com/NixOS/nixpkgs/pull/101876
1 package marked as broken and skipped:
maxima-ecl

This is because ecl is marked broken on darwin.

@omasanori omasanori mentioned this pull request Oct 28, 2020
10 tasks
@omasanori
Copy link
Contributor Author

@omasanori omasanori commented Nov 2, 2020

Same as #101830 (comment), I close this for now.

@omasanori omasanori closed this Nov 2, 2020
@omasanori omasanori deleted the maxima/update-5.44.0 branch Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants