Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgresqlPackages.periods: 1.1 -> 1.2 #101878

Merged
merged 1 commit into from Oct 27, 2020
Merged

postgresqlPackages.periods: 1.1 -> 1.2 #101878

merged 1 commit into from Oct 27, 2020

Conversation

@ivan
Copy link
Member

@ivan ivan commented Oct 27, 2020

Motivation for this change

https://github.com/xocolatl/periods/commits

periods 1.2 is required to pg_upgrade from PostgreSQL 12 to 13. periods must be upgraded in each database before pg_upgrade can succeed (otherwise you see this error - ref xocolatl/periods@58e30e5)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I tested an upgrade of periods from 1.1 to 1.2 in PostgreSQL 12 and I tested that PostgreSQL 13 can load periods 1.2.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 27, 2020

Run on darwin:

Result of nixpkgs-review pr 101878 1

1 package built:
  • postgresqlPackages.periods (postgresql11Packages.periods)

@marsam marsam merged commit b5d10cb into NixOS:master Oct 27, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants