Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs-14_x: 14.14.0 -> 14.15.0 #101891

Merged
merged 1 commit into from Oct 28, 2020
Merged

nodejs-14_x: 14.14.0 -> 14.15.0 #101891

merged 1 commit into from Oct 28, 2020

Conversation

@punkeel
Copy link
Contributor

@punkeel punkeel commented Oct 28, 2020

https://github.com/nodejs/node/releases/tag/v14.15.0

Motivation for this change

Upgrade Node.js to v14.15.0, which is the new LTS. See release blog post

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Previous upgrade PR #100675

@punkeel
Copy link
Contributor Author

@punkeel punkeel commented Oct 28, 2020

Two open questions

  • Should this commit be ported to release-20.09? Is this done automatically?
  • Should nodejs be switched to 14.15, as it has become the Node.js LTS version? Should it be done in 20.10 (or 21.04, I'm not really aware of the versioning scheme)?

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 28, 2020

Is this done automatically?

Nope.

@marsam
Copy link
Contributor

@marsam marsam commented Oct 28, 2020

Thank you for your contribution

Should this commit be ported to release-20.09? Is this done automatically?

We backport mostly security-relevant commits, and currently it's done manually.
In this case, I don't think we need to backport it.

Should nodejs be switched to 14.15, as it has become the Node.js LTS version? Should it be done in 20.10 (or 21.04, I'm not really aware of the versioning scheme)?

yes, we should should switch to nodejs-14_x as the default for 21.03

@marsam marsam merged commit 10a713e into NixOS:master Oct 28, 2020
19 checks passed
@punkeel punkeel deleted the patch-1 branch Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants