Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a directory-category for terminal emulators #101894

Merged
merged 2 commits into from Oct 29, 2020

Conversation

@AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Oct 28, 2020

This is a mostly cosmetical commit, in the sense it doesn't change the contents
of any package, but reorganizes the overall Nixpkgs expressions.

Terminal emulators are an ubiquitous tool for any Unix user; even the beginners
are routinely familiarized to it. And, manifestly, there are many
implementations of terminal emulators out there, from those traditionally made
in C and C++ to those written in Haskell and Go.

Terminal emulators deserve more highlight. This commit does that by creating a
category for them.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
This is a mostly cosmetical commit, in the sense it doesn't change the contents
of any package, but reorganizes the overall Nixpkgs expressions.

Terminal emulators are an ubiquitous tool for any Unix user; even the beginners
are routinely familiarized to it. And, manifestly, there are many
implementations of terminal emulators out there, from those traditionally made
in C and C++ to those written in Haskell and Go.

Terminal emulators deserve more highlight. This commit does that by creating a
category for them.
@AndersonTorres
Copy link
Member Author

@AndersonTorres AndersonTorres commented Oct 28, 2020

The only errors(?) found here are trailing whitespaces. This implies everything is OK, the expressions weren't affected by its relocation.

So, I will add a new commit only for this small fix.

@AndersonTorres AndersonTorres force-pushed the AndersonTorres:terminal-emulators branch from 388c1b6 to 2bb3a9d Oct 28, 2020
@AndersonTorres AndersonTorres requested a review from grahamc Oct 28, 2020
@berbiche
Copy link
Member

@berbiche berbiche commented Oct 28, 2020

Should they also be grouped together in all-packages.nix?

@AndersonTorres
Copy link
Member Author

@AndersonTorres AndersonTorres commented Oct 28, 2020

@berbiche you said in a sense they are all grouped in a contiguous place?

Well, it is a bit controversial. The "ordered all-packages.nix" was lost a long time ago.

It can certainly be done, but I am being more conservative here: I just get all references to terminal emulators and moved them.

@berbiche
Copy link
Member

@berbiche berbiche commented Oct 28, 2020

Some maintainers are still adhering to the "ordered all-packages.nix" (which happened to one of my contribution listed here 😄) and thus I bringing up the subject.

@AndersonTorres
Copy link
Member Author

@AndersonTorres AndersonTorres commented Oct 28, 2020

@berbiche behold!

@AndersonTorres AndersonTorres force-pushed the AndersonTorres:terminal-emulators branch from 338c1b5 to 58867ed Oct 28, 2020
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Oct 28, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/a-directory-category-for-terminal-emulators/9698/1

Copy link
Member

@cdepillabout cdepillabout left a comment

LGTM.

I'm the maintainer of termonad, and I remember that when I added termonad, I was surprised there wasn't already a category for terminal emulators.

Because editorconfig complains, and also why not to organize them
"ascii-betically"?
@AndersonTorres AndersonTorres force-pushed the AndersonTorres:terminal-emulators branch from 58867ed to 5b5aac4 Oct 29, 2020
@AndersonTorres AndersonTorres merged commit 066bf7d into NixOS:master Oct 29, 2020
16 checks passed
16 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5b5aac4"; rev="5b5aac40d5675f04f6b0d987dd75e20337d487e0"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5b5aac4"; rev="5b5aac40d5675f04f6b0d987dd75e20337d487e0"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5b5aac4"; rev="5b5aac40d5675f04f6b0d987dd75e20337d487e0"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5b5aac4"; rev="5b5aac40d5675f04f6b0d987dd75e20337d487e0"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5b5aac4"; rev="5b5aac40d5675f04f6b0d987dd75e20337d487e0"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5b5aac4"; rev="5b5aac40d5675f04f6b0d987dd75e20337d487e0"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5b5aac4"; rev="5b5aac40d5675f04f6b0d987dd75e20337d487e0"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@AndersonTorres AndersonTorres changed the title A directory-category for terminal emulators Create a directory-category for terminal emulators Oct 29, 2020
@AndersonTorres AndersonTorres deleted the AndersonTorres:terminal-emulators branch Oct 29, 2020
@romildo
Copy link
Contributor

@romildo romildo commented Oct 29, 2020

The section ### APPLICATIONS/TERMINAL-EMULATORS should have gone just before or after another section, as @berbiche suggested. Leaving it in the middle of another section is strange. The last terminal emulator in the list (yaft) is immediately followed by a package that is not a terminal emulator (aldo) without any intercalating comment. This would classify yaft as a terminal emulator too.
It would be wise (in a new PR) to move this block so that it stays after the section ### APPLICATIONS, immediately before ### BLOCKCHAINS / CRYPTOCURRENCIES / WALLETS.

@AndersonTorres
Copy link
Member Author

@AndersonTorres AndersonTorres commented Oct 30, 2020

@romildo

I am now working on reorder this file. As I said before, it is a beautiful mess, and I will "fix" it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants