Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.hex: 1.3.0 → 1.4.0 #101897

Merged
merged 2 commits into from Oct 31, 2020
Merged

ocamlPackages.hex: 1.3.0 → 1.4.0 #101897

merged 2 commits into from Oct 31, 2020

Conversation

@vbgl
Copy link
Contributor

@vbgl vbgl commented Oct 28, 2020

Motivation for this change

Use Dune 2.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 28, 2020

Result of nixpkgs-review pr 101897 1 run on x86_64-darwin

1 package failed to build:
  • dune-release
5 packages built:
  • jackline
  • libbap
  • python27Packages.bap
  • python37Packages.bap
  • python38Packages.bap

Manually building dune-release succeeds.

Copy link
Member

@sternenseemann sternenseemann left a comment

LGTM, nixpkgs-review on x86_64 linux succeeds.

useDune2 for fiat-p256 is good and is required for 0.2.2 anyways. Btw, I looked into updating fiat-p256, hacl_x25519 and cstruct the past few days and seems like we have a bit of a dependency hell with ppx in store, since it seems we need at least 3 different versions of ppxlib in nixpkgs in the future.

@vbgl vbgl merged commit 39dbc77 into NixOS:master Oct 31, 2020
17 checks passed
17 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8cf6bbf"; rev="8cf6bbf38888843102cada38b4652689efb57c28"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8cf6bbf"; rev="8cf6bbf38888843102cada38b4652689efb57c28"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8cf6bbf"; rev="8cf6bbf38888843102cada38b4652689efb57c28"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8cf6bbf"; rev="8cf6bbf38888843102cada38b4652689efb57c28"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8cf6bbf"; rev="8cf6bbf38888843102cada38b4652689efb57c28"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8cf6bbf"; rev="8cf6bbf38888843102cada38b4652689efb57c28"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8cf6bbf"; rev="8cf6bbf38888843102cada38b4652689efb57c28"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@vbgl vbgl deleted the vbgl:ocaml-hex-1.4.0 branch Oct 31, 2020
@vbgl
Copy link
Contributor Author

@vbgl vbgl commented Nov 1, 2020

seems like we have a bit of a dependency hell

I haven’t reached that conclusion yet, but indeed, it is kind of messy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants