Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpxsee: 7.33 → 7.35 #101902

Merged
merged 1 commit into from Nov 4, 2020
Merged

gpxsee: 7.33 → 7.35 #101902

merged 1 commit into from Nov 4, 2020

Conversation

@sikmir
Copy link
Member

@sikmir sikmir commented Oct 28, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 28, 2020

Run on darwin:

Result of nixpkgs-review pr 101902 1

1 package failed to build:
  • gpxsee

@sikmir
Copy link
Member Author

@sikmir sikmir commented Oct 28, 2020

@SuperSandro2000 Could you please provide more details what is failed? For me build is OK on nixos and macos.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 28, 2020

I just tried mass building PRs so I am not 100% confident nothing went wrong:

configuring
/nix/store/jrdnj4yvpp4f33bcac4hv1v7zcjpq8jq-stdenv-darwin/setup: line 89: 58288 Segmentation fault: 11  lrelease gpxsee.pro

Copy link
Member

@rapenne-s rapenne-s left a comment

Works fine on Nixos amd64
Changes on the nix file looks fine to me.

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Nov 4, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/278

@kevincox kevincox merged commit 2802d2a into NixOS:master Nov 4, 2020
19 checks passed
@sikmir sikmir deleted the gpxsee branch Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants