Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs-10_x: 10.22.1 -> 10.23.0 #101912

Merged
merged 1 commit into from Oct 28, 2020
Merged

nodejs-10_x: 10.22.1 -> 10.23.0 #101912

merged 1 commit into from Oct 28, 2020

Conversation

@marsam
Copy link
Contributor

@marsam marsam commented Oct 28, 2020

Motivation for this change

https://github.com/nodejs/node/releases/tag/v10.23.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@marsam marsam force-pushed the update-nodejs-10_x branch from b6bb782 to 83d9ca8 Oct 28, 2020
@marsam marsam merged commit 742e5e5 into NixOS:master Oct 28, 2020
19 of 20 checks passed
@marsam marsam deleted the update-nodejs-10_x branch Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant