Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Freecad fixes AddonManager bug #101915

Closed
wants to merge 1 commit into from

Conversation

@tarnacious
Copy link

@tarnacious tarnacious commented Oct 28, 2020

I'm seeing the bug mentioned in the FreeCad commit below that prevents the AddonManager working in the packaged version in 20.03 and in the packaged version on master.

FreeCAD/FreeCAD@72eb41b

This PR updates the FreeCad package to the commit which was the most recently committed on FreeCad master when I built the latest version, it includes the fix.

FreeCAD/FreeCAD@0f87516

The hash I got running:

nix-prefetch-url --type sha256 https://github.com/FreeCad/FreeCad/archive/0f875168b67536fd859ed44e1fe50d9b0a11f223.tar.gz

Didn't work, so I just used the hast the build expected.

Not concerned if this PR doesn't get merged more an FYI that the current version seems to have an issue with the AddonManager.

Cheers

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [yes] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
I'm seeing this bug the prevents the AddonManager working on the 20.03
and on master I think. Updating freecad-unstable to a newer version that
include this commit fixes the issue for me.

FreeCAD/FreeCAD@72eb41b
@tarnacious
Copy link
Author

@tarnacious tarnacious commented Oct 28, 2020

It's possible you can disregard this. I've just updated my system 20.09 and the version in the stable channel seems not break.

@tarnacious
Copy link
Author

@tarnacious tarnacious commented Oct 28, 2020

Hm, on the 20.09 version, I'm not getting the error but I'm also not seeing any workbenches to install. I'm trying to rebuild the version in this commit, but it takes some time.

@tarnacious
Copy link
Author

@tarnacious tarnacious commented Oct 28, 2020

Ok, it looks like the current version on master doesn't have the original error and loads workbenches to install, so this commit can be disregarded, sorry about that. i think it's still an issue that the package on staging doesn't work, should I close this PR and create an issue for that?

@tarnacious tarnacious closed this Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant