Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pytorch: 1.6.0 -> 1.7.0 #101917

Merged
merged 1 commit into from Nov 11, 2020
Merged

Conversation

@danieldk
Copy link
Member

@danieldk danieldk commented Oct 28, 2020

Motivation for this change

Changelog:

https://github.com/pytorch/pytorch/releases/tag/v1.7.0

Todo: test CUDA build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@danieldk
Copy link
Member Author

@danieldk danieldk commented Oct 28, 2020

@ofborg build python37Packages.pytorch python38Packages.pytorch

@danieldk
Copy link
Member Author

@danieldk danieldk commented Nov 2, 2020

AArch64 fails with

aten/src/ATen/native/cpu/GridSamplerKernel.cpp.DEFAULT.cpp:519:3: internal compiler error: Max. number of generated reload insns per insn is achieved (90)

Could be this issue:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96796

danieldk added a commit to danieldk/nixpkgs that referenced this issue Nov 2, 2020
danieldk added a commit to danieldk/nixpkgs that referenced this issue Nov 2, 2020
@danieldk
Copy link
Member Author

@danieldk danieldk commented Nov 11, 2020

Updated to fix incorrect paths in CMake files.

@ofborg build python37Packages.pytorch python38Packages.pytorch

@danieldk danieldk merged commit 5e93492 into NixOS:master Nov 11, 2020
18 of 19 checks passed
@danieldk danieldk deleted the pytorch-1.7.0 branch Nov 11, 2020
@danieldk
Copy link
Member Author

@danieldk danieldk commented Nov 11, 2020

Edit: whoops, merged the wrong PR, too many tabs open.

I can revert this if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant