Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextcloud: 19.0.3 -> 19.0.4, 18.0.9 -> 18.0.10 #101923

Merged
merged 2 commits into from Nov 6, 2020
Merged

Conversation

@xfix
Copy link
Contributor

@xfix xfix commented Oct 28, 2020

Motivation for this change

Getting Nextcloud to stop informing me about updates.

Please backport this to 20.09 as Nextcloud doesn't support downgrades.

20.0.1 makes dashboard load faster and fixes a deadlock: https://nextcloud.com/blog/20-0-1-is-here-with-about-60-changes-get-your-update/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@xfix
Copy link
Contributor Author

@xfix xfix commented Oct 28, 2020

@ofborg build nextcloud20 nextcloud19 nextcloud18

I'm not sure if ofborg will be fine with building Nextcloud 18 because it's insecure, but eh, may as well list that.

@ofborg test nextcloud

@xfix xfix changed the title Nextcloud updates nextcloud: 20.0.0 -> 20.0.1, 19.0.3 -> 19.0.4, 18.0.9 -> 18.0.10 Oct 28, 2020
@xfix
Copy link
Contributor Author

@xfix xfix commented Oct 28, 2020

@ofborg test nextcloud.basic nextcloud.with-postgresql-and-redis nextcloud.with-mysql-and-memcached

@xfix
Copy link
Contributor Author

@xfix xfix commented Oct 28, 2020

Ran an update to Nextcloud 20.0.1 in production on my server: https://gitlab.com/KonradBorowski/xfix.pw/-/commit/287977e9f9957ebcec9e8067257e0b5b5a951cb4, no issues, everything works as it should.

bachp
bachp approved these changes Oct 28, 2020
Copy link
Member

@bachp bachp left a comment

19.0.4 update is working without issues

@Ma27
Copy link
Member

@Ma27 Ma27 commented Nov 3, 2020

The 20.0.1 update is already in master from another PR, so it can be removed here. The rest seems fine IMHO.

@xfix xfix force-pushed the nextcloud-updates branch from dd28223 to 7a36e41 Nov 3, 2020
@xfix xfix changed the title nextcloud: 20.0.0 -> 20.0.1, 19.0.3 -> 19.0.4, 18.0.9 -> 18.0.10 nextcloud: 19.0.3 -> 19.0.4, 18.0.9 -> 18.0.10 Nov 3, 2020
@xfix
Copy link
Contributor Author

@xfix xfix commented Nov 3, 2020

Sure, not like it matters either way, but may as well rebase newest master. I think git would remove already merged-in commits during merge process.

@ofborg ofborg bot requested a review from bachp Nov 3, 2020
@Ma27
Copy link
Member

@Ma27 Ma27 commented Nov 3, 2020

Just verified with git 2.28 that it would cause a merge conflict when using a trivial git merge, also both bumps would be in the history probably causing confusion. Not sure if GitHub is smart enough to actually resolve this.
IIRC what you describe only happens during a rebase.

Ma27
Ma27 approved these changes Nov 6, 2020
@Ma27 Ma27 merged commit 115f769 into NixOS:master Nov 6, 2020
19 checks passed
19 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7a36e41"; rev="7a36e413755a857a48d8ecb8075c78d05e61a0b8"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7a36e41"; rev="7a36e413755a857a48d8ecb8075c78d05e61a0b8"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7a36e41"; rev="7a36e413755a857a48d8ecb8075c78d05e61a0b8"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7a36e41"; rev="7a36e413755a857a48d8ecb8075c78d05e61a0b8"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7a36e41"; rev="7a36e413755a857a48d8ecb8075c78d05e61a0b8"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7a36e41"; rev="7a36e413755a857a48d8ecb8075c78d05e61a0b8"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7a36e41"; rev="7a36e413755a857a48d8ecb8075c78d05e61a0b8"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg[bot]
nextcloud18, nextcloud18.passthru.tests, nextcloud19, nextcloud19.passthru.tests on aarch64-linux Success
Details
@ofborg[bot]
nextcloud18, nextcloud18.passthru.tests, nextcloud19, nextcloud19.passthru.tests on x86_64-linux Success
Details
@Ma27
Copy link
Member

@Ma27 Ma27 commented Nov 6, 2020

Thanks! Ported to stable 24b3800, b1acf67.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants