Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] python3Packages.cryptography: 3.1 -> 3.2 (security, CVE-2020-25659) #101928

merged 2 commits into from Oct 28, 2020


Copy link

@primeos primeos commented Oct 28, 2020

Motivation for this change

Backport of #101751.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
primeos added 2 commits Oct 28, 2020
SECURITY ISSUE: Attempted to make RSA PKCS#1v1.5 decryption more
constant time, to protect against Bleichenbacher vulnerabilities. Due to
limitations imposed by our API, we cannot completely mitigate this
vulnerability and a future release will contain a new API which is
designed to be resilient to these for contexts where it is required.
Credit to Hubert Kario for reporting the issue. CVE-2020-25659

(cherry picked from commit 1083cdd)
Copy link

@jonringer jonringer commented Oct 28, 2020

@GrahamcOfBorg build python3Packages.requests

Copy link

@jonringer jonringer left a comment

diff LGTM

waiting on borg

Copy link

@jonringer jonringer commented Oct 28, 2020

was able to build python3Packages.requests locally

@jonringer jonringer merged commit 692ad4a into NixOS:staging-20.09 Oct 28, 2020
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants