Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take maintainership for a few packages #101932

Merged
merged 5 commits into from Oct 28, 2020

Conversation

@matthiasbeyer
Copy link
Contributor

@matthiasbeyer matthiasbeyer commented Oct 28, 2020

Motivation for this change

Leon (@lschuermann) has informed me that he has too little time to take care of these, so I would like to take maintainership.
Some things are still maintained by Leon, though, as I do not feel confident in taking maintainership of these things (mainly services, esp. services I do not use myself).

Waiting for approval of @lschuermann

@matthiasbeyer
Copy link
Contributor Author

@matthiasbeyer matthiasbeyer commented Oct 28, 2020

These patches should, if approved, probably be backported to nixos-20.03 and nixos-20.09.

This patch changes maintainership for this package from lschuermann to
matthiasbeyer.
Leon has informed me in a private conversation that he has too little
time to take care of the packages, so I will (maybe only temporarly,
maybe not) take maintainership for it.

Suggested-by: Leon Schuermann <leon@is.currently.online>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
This patch changes maintainership for this package from lschuermann to
matthiasbeyer.
Leon has informed me in a private conversation that he has too little
time to take care of the packages, so I will (maybe only temporarly,
maybe not) take maintainership for it.

Suggested-by: Leon Schuermann <leon@is.currently.online>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
This patch changes maintainership for this package from lschuermann to
matthiasbeyer.
Leon has informed me in a private conversation that he has too little
time to take care of the packages, so I will (maybe only temporarly,
maybe not) take maintainership for it.

Suggested-by: Leon Schuermann <leon@is.currently.online>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
This patch changes maintainership for this package from lschuermann to
matthiasbeyer.
Leon has informed me in a private conversation that he has too little
time to take care of the packages, so I will (maybe only temporarly,
maybe not) take maintainership for it.

Suggested-by: Leon Schuermann <leon@is.currently.online>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
This patch changes maintainership for this package from lschuermann to
matthiasbeyer.
Leon has informed me in a private conversation that he has too little
time to take care of the packages, so I will (maybe only temporarly,
maybe not) take maintainership for it.

Suggested-by: Leon Schuermann <leon@is.currently.online>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@lschuermann
Copy link
Member

@lschuermann lschuermann commented Oct 28, 2020

Currently I'm at capacity and hence appreciate the effort @matthiasbeyer. In the future I'd be very interesting in continuing to maintain and further develop these and hence would create a PR to revert the change. Does this work for you @matthiasbeyer?

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 28, 2020

If you don't replace but add the maintainer you don't need to revert in the future.

@matthiasbeyer
Copy link
Contributor Author

@matthiasbeyer matthiasbeyer commented Oct 28, 2020

Everything alright for me, thanks!

If you don't replace but add the maintainer you don't need to revert in the future.

Yes, but I would like to give maintainership back then, not just drop maintainership for me.
Like, I would take it temporarily but if Leon takes it back, give it back completely.

So this is exactly as intended.

@jonringer jonringer merged commit e655d6f into NixOS:master Oct 28, 2020
18 of 19 checks passed
@matthiasbeyer matthiasbeyer deleted the take-maintainership branch Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants