Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

img-cat: init at 1.2.0 #101937

Merged
merged 1 commit into from Dec 8, 2020
Merged

img-cat: init at 1.2.0 #101937

merged 1 commit into from Dec 8, 2020

Conversation

@penguwin
Copy link
Member

@penguwin penguwin commented Oct 28, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 28, 2020

Result of nixpkgs-review pr 101937 1 run on x86_64-darwin

1 package built:
  • img-cat

@penguwin penguwin force-pushed the penguwin:img-cat branch from f9c9583 to daabf07 Oct 29, 2020
@penguwin penguwin requested a review from sikmir Oct 30, 2020
@sikmir
sikmir approved these changes Oct 30, 2020
@penguwin penguwin force-pushed the penguwin:img-cat branch from daabf07 to a8b3cb1 Nov 12, 2020
@penguwin penguwin changed the title img-cat: init at 1.1.1 img-cat: init at 1.2.0 Nov 12, 2020
@penguwin penguwin requested a review from sikmir Nov 12, 2020
@sikmir
sikmir approved these changes Nov 12, 2020
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 24, 2020

Result of nixpkgs-review pr 101937 run on x86_64-linux 1

1 package built:
  • img-cat

@penguwin penguwin force-pushed the penguwin:img-cat branch from a8b3cb1 to ff7f34e Nov 25, 2020
@penguwin penguwin requested a review from SuperSandro2000 Nov 25, 2020
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 26, 2020

Result of nixpkgs-review pr 101937 run on x86_64-linux 1

1 package built:
  • img-cat

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 8, 2020

Result of nixpkgs-review pr 101937 run on x86_64-darwin 1

1 package built:
  • img-cat

@SuperSandro2000 SuperSandro2000 merged commit 4085eec into NixOS:master Dec 8, 2020
19 checks passed
19 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ff7f34e"; rev="ff7f34e7bf598377072ac878390e000370b98fac"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ff7f34e"; rev="ff7f34e7bf598377072ac878390e000370b98fac"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ff7f34e"; rev="ff7f34e7bf598377072ac878390e000370b98fac"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ff7f34e"; rev="ff7f34e7bf598377072ac878390e000370b98fac"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ff7f34e"; rev="ff7f34e7bf598377072ac878390e000370b98fac"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ff7f34e"; rev="ff7f34e7bf598377072ac878390e000370b98fac"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ff7f34e"; rev="ff7f34e7bf598377072ac878390e000370b98fac"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg
img-cat, img-cat.passthru.tests on aarch64-linux Success
Details
@ofborg
img-cat, img-cat.passthru.tests on x86_64-linux Success
Details
@penguwin penguwin deleted the penguwin:img-cat branch Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants