Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnomeExtensions.clipboard-indicator: 34 -> 37 #101939

Merged

Conversation

@jonafato
Copy link
Contributor

@jonafato jonafato commented Oct 28, 2020

Motivation for this change

clipboard-indicator has a new release. Most notably, this adds support
for GNOME 3.38 and drops support for 3.36 (note that while the extension
no longer lists 3.36 as a supported version, it does still work).

Full changelog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
clipboard-indicator has a new release. Most notably, this adds support
for GNOME 3.38 and drops support for 3.36 (note that while the extension
no longer lists 3.36 as a supported version, it does still work).

[Full changelog](Tudmotu/gnome-shell-extension-clipboard-indicator@v34...v37)
@jonafato
Copy link
Contributor Author

@jonafato jonafato commented Nov 13, 2020

@NixOS/gnome Now that 3.38 is on master, can I get a review on this update? The extension is broken on 3.38 without this version bump.

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Nov 13, 2020

Changes look fine to me.

@jtojnar jtojnar merged commit cb0be69 into NixOS:master Nov 13, 2020
19 checks passed
19 checks passed
tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
gnomeExtensions.clipboard-indicator, gnomeExtensions.clipboard-indicator.passthru.tests on aarch64-linux Success
Details
gnomeExtensions.clipboard-indicator, gnomeExtensions.clipboard-indicator.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3c122da"; rev="3c122da4a5bd8916215af8e6d208725104706255"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3c122da"; rev="3c122da4a5bd8916215af8e6d208725104706255"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3c122da"; rev="3c122da4a5bd8916215af8e6d208725104706255"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3c122da"; rev="3c122da4a5bd8916215af8e6d208725104706255"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3c122da"; rev="3c122da4a5bd8916215af8e6d208725104706255"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3c122da"; rev="3c122da4a5bd8916215af8e6d208725104706255"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3c122da"; rev="3c122da4a5bd8916215af8e6d208725104706255"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jonafato jonafato deleted the jonafato:gnome-shell-extension-clipboard-indicator-37 branch Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants