Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ns-3: 3.30 -> 3.32 #101943

merged 1 commit into from Oct 28, 2020

ns-3: 3.30 -> 3.32 #101943

merged 1 commit into from Oct 28, 2020


Copy link

@eyJhb eyJhb commented Oct 28, 2020

Motivation for this change

Bugfixes and this - #100770

Keep in mind there is a cheap patch to bypass this issue mentioned here - #69310

I have added "point-to-point-layout", as netanim would not work without it.

All libs now has the name of libns3.32-...-debug instead of libns3-dev-...-debug, not sure if we should do anything about that?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
Copy link

@SuperSandro2000 SuperSandro2000 commented Oct 28, 2020

Result of nixpkgs-review pr 101943 1 run on x86_64-darwin

1 package built:
  • ns-3

Copy link

@teto teto commented Oct 28, 2020

thanks for the patch. It passed nixpkgs-review here. You've arrived just in time, a bit more and the package would have disappeared :) #100770

@teto teto merged commit 4ce6364 into NixOS:master Oct 28, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants