Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSCAR: init at 1.2.0 #101945

Merged
merged 1 commit into from Nov 1, 2020
Merged

OSCAR: init at 1.2.0 #101945

merged 1 commit into from Nov 1, 2020

Conversation

@roconnor
Copy link
Contributor

@roconnor roconnor commented Oct 28, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
pkgs/applications/misc/OSCAR/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/OSCAR/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/OSCAR/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/OSCAR/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/OSCAR/default.nix Show resolved Hide resolved
pkgs/applications/misc/OSCAR/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/OSCAR/default.nix Outdated Show resolved Hide resolved
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Pressed the wrong button.

@roconnor roconnor force-pushed the OSCAR branch 2 times, most recently from f8c2491 to 76729bb Oct 29, 2020
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

When building on darwin I get:

clang++ -stdlib=libc++ -o OSCAR.app/Contents/MacOS/OSCAR checkupdates.o common_gui.o cprogressbar.o daily.o exportcsv.o main.o mainwindow.o newprofile.o overview.o preferencesdialog.o reports.o sessionbar.o version.o gFlagsLine.o gFooBar.o gGraph.o gGraphView.o glcommon.o gLineChart.o gLineOverlay.o gSegmentChart.o gspacer.o gStatsLine.o gSummaryChart.o gXAxis.o gYAxis.o layer.o calcs.o common.o day.o event.o machine.o machine_loader.o preferences.o profiles.o schema.o session.o cms50_loader.o dreem_loader.o icon_loader.o intellipap_loader.o mseries_loader.o prs1_loader.o resmed_loader.o resmed_EDFinfo.o somnopose_loader.o viatom_loader.o zeo_loader.o zip.o miniz.o csv.o translation.o statistics.o oximeterimport.o deviceconnection.o xmlreplay.o serialoximeter.o md300w1_loader.o gSessionTimesChart.o gPressureChart.o logger.o machine_common.o weinmann_loader.o gdailysummary.o MinutesAtPressure.o journal.o progressdialog.o cms50f37_loader.o profileselector.o appsettings.o edfparser.o aboutdialog.o welcome.o qrc_Resources.o moc_checkupdates.o moc_daily.o moc_exportcsv.o moc_mainwindow.o moc_newprofile.o moc_overview.o moc_preferencesdialog.o moc_sessionbar.o moc_gGraph.o moc_gGraphView.o moc_machine_loader.o moc_cms50_loader.o moc_icon_loader.o moc_prs1_loader.o moc_resmed_loader.o moc_zip.o moc_statistics.o moc_oximeterimport.o moc_deviceconnection.o moc_serialoximeter.o moc_md300w1_loader.o moc_logger.o moc_progressdialog.o moc_cms50f37_loader.o moc_profileselector.o moc_aboutdialog.o moc_welcome.o moc_mytextbrowser.o   -lz /nix/store/nsk1zf0vf7mzz68may1vcw8jrvgpc4y9-qtbase-5.12.7/lib/libQt5PrintSupport.dylib /nix/store/nsk1zf0vf7mzz68may1vcw8jrvgpc4y9-qtbase-5.12.7/lib/libQt5OpenGL.dylib /nix/store/nsk1zf0vf7mzz68may1vcw8jrvgpc4y9-qtbase-5.12.7/lib/libQt5Widgets.dylib /nix/store/nsk1zf0vf7mzz68may1vcw8jrvgpc4y9-qtbase-5.12.7/lib/libQt5Gui.dylib /nix/store/nsk1zf0vf7mzz68may1vcw8jrvgpc4y9-qtbase-5.12.7/lib/libQt5Network.dylib /nix/store/nsk1zf0vf7mzz68may1vcw8jrvgpc4y9-qtbase-5.12.7/lib/libQt5Xml.dylib /nix/store/23c1aapqj8dmjav276c7bvj1s29i9zac-qtserialport-5.12.7/lib/libQt5SerialPort.dylib /nix/store/nsk1zf0vf7mzz68may1vcw8jrvgpc4y9-qtbase-5.12.7/lib/libQt5Core.dylib -framework OpenGL -framework AGL
make[1]: Leaving directory '/private/var/folders/r4/k85s52jx3555ckj0wty615s00000gp/T/nix-build-OSCAR-1.2.0.drv-0/source/oscar'
installing
install: cannot stat 'oscar/OSCAR': No such file or directory
builder for '/nix/store/qx32zggysfgp2sz5nr3680f7pfb5400l-OSCAR-1.2.0.drv' failed with exit code 1
error: build of '/nix/store/qx32zggysfgp2sz5nr3680f7pfb5400l-OSCAR-1.2.0.drv' failed

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 29, 2020

Result of nixpkgs-review pr 101945 run on x86_64-linux 1

1 package failed to build:
  • OSCAR
QMAKEPATH=/nix/store/gnbsmzcp9n66vssz1sfv2yw26fd9xkb5-qtbase-5.15.0-dev:/nix/store/gnbsmzcp9n66vssz1sfv2yw26fd9xkb5-qtbase-5.15.0-dev:/nix/store/gnbsmzcp9n66vssz1sfv2yw26fd9xkb5-qtbase-5.15.0-dev:/nix/store/wacsr6pz13cvz7f6ih8v67yqj38sbvid-qtwayland-5.15.0-dev:/nix/store/wacsr6pz13cvz7f6ih8v67yqj38sbvid-qtwayland-5.15.0-dev:/nix/store/wacsr6pz13cvz7f6ih8v67yqj38sbvid-qtwayland-5.15.0-dev:/nix/store/6vwwszsgsjnh794xfmbfacm5kk94ja2r-qtdeclarative-5.15.0-dev:/nix/store/6vwwszsgsjnh794xfmbfacm5kk94ja2r-qtdeclarative-5.15.0-dev:/nix/store/6vwwszsgsjnh794xfmbfacm5kk94ja2r-qtdeclarative-5.15.0-dev:/nix/store/1rvchzwm3c96i1dikdx43h5d7krjhb1l-qtsvg-5.15.0-dev:/nix/store/1rvchzwm3c96i1dikdx43h5d7krjhb1l-qtsvg-5.15.0-dev:/nix/store/1rvchzwm3c96i1dikdx43h5d7krjhb1l-qtsvg-5.15.0-dev:/nix/store/z4asv7pi13zwb5wif4ibirjp0i5xv4y4-qttools-5.15.0-dev:/nix/store/z4asv7pi13zwb5wif4ibirjp0i5xv4y4-qttools-5.15.0-dev:/nix/store/z4asv7pi13zwb5wif4ibirjp0i5xv4y4-qttools-5.15.0-dev:/nix/store/76j9qcdl6gl6bkcjqa1mn6b8ivdf9pd9-qtserialport-5.15.0-dev:/nix/store/76j9qcdl6gl6bkcjqa1mn6b8ivdf9pd9-qtserialport-5.15.0-dev:/nix/store/76j9qcdl6gl6bkcjqa1mn6b8ivdf9pd9-qtserialport-5.15.0-dev
qmake PREFIX=/nix/store/6dn4vrwazddcd12894a8fnv256wyg3h1-OSCAR-1.2.0 NIX_OUTPUT_OUT=/nix/store/6dn4vrwazddcd12894a8fnv256wyg3h1-OSCAR-1.2.0 NIX_OUTPUT_DEV=/nix/store/6dn4vrwazddcd12894a8fnv256wyg3h1-OSCAR-1.2.0 NIX_OUTPUT_BIN=/nix/store/6dn4vrwazddcd12894a8fnv256wyg3h1-OSCAR-1.2.0 NIX_OUTPUT_DOC=/nix/store/6dn4vrwazddcd12894a8fnv256wyg3h1-OSCAR-1.2.0/share/doc/qt-5.15.0 NIX_OUTPUT_QML=/nix/store/6dn4vrwazddcd12894a8fnv256wyg3h1-OSCAR-1.2.0/lib/qt-5.15.0/qml NIX_OUTPUT_PLUGIN=/nix/store/6dn4vrwazddcd12894a8fnv256wyg3h1-OSCAR-1.2.0/lib/qt-5.15.0/plugins CONFIG+=release OSCAR_QT.pro QMAKE_LRELEASE=/nix/store/z4asv7pi13zwb5wif4ibirjp0i5xv4y4-qttools-5.15.0-dev/bin/lrelease
Project ERROR: Cannot run compiler 'g++'. Output:
===================
===================
Maybe you forgot to setup the environment?

@roconnor
Copy link
Contributor Author

@roconnor roconnor commented Oct 29, 2020

I don't know how to install on darwin.

@roconnor
Copy link
Contributor Author

@roconnor roconnor commented Oct 29, 2020

nixpkgs-review pr 101945 works for me:

$ nix-store -q --deriver /nix/store/6dn4vrwazddcd12894a8fnv256wyg3h1-OSCAR-1.2.0/bin/OSCAR
/nix/store/20ggyh6f5nm6c28cv5rjafvcknnk3d9w-OSCAR-1.2.0.drv

(note I have the same /nix/store output hash that you have.)

@roconnor
Copy link
Contributor Author

@roconnor roconnor commented Oct 29, 2020

Added meta.broken for non-linux.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 31, 2020

I don't know how to install on darwin.

That is okay. If anyone wants to fix it for darwin they can do it in the future.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 31, 2020

Result of nixpkgs-review pr 101945 run on x86_64-linux 1

1 package built:
  • OSCAR

@roconnor roconnor merged commit eaf06c3 into NixOS:master Nov 1, 2020
19 checks passed
@roconnor roconnor deleted the OSCAR branch Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants