Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audiowaveform: init at 1.4.2 #101947

Merged
merged 2 commits into from Dec 11, 2020
Merged

audiowaveform: init at 1.4.2 #101947

merged 2 commits into from Dec 11, 2020

Conversation

@edbentley
Copy link
Contributor

@edbentley edbentley commented Oct 28, 2020

Motivation for this change

Adding the audiowaveform CLI program. Used their homebrew file as a reference.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@edbentley
Copy link
Contributor Author

@edbentley edbentley commented Oct 28, 2020

@SuperSandro2000 thanks for the quick feedback, updated.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 28, 2020

Result of nixpkgs-review pr 101947 1 run on x86_64-darwin

1 package built:
  • audiowaveform

@edbentley
Copy link
Contributor Author

@edbentley edbentley commented Oct 29, 2020

@sikmir Updated, thanks for the feedback.

@edbentley
Copy link
Contributor Author

@edbentley edbentley commented Nov 1, 2020

I think everything is ready here, can this be merged? 😄

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

and please squash the current 4 commits together. After that we can merge.

maintainers/maintainer-list.nix Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 25, 2020

Also please squash the review related commits into the init ones.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 25, 2020

One test is failing:

[       OK ] SndFileAudioFileReaderTest.shouldNotProcessFileMoreThanOnce (1 ms)
[ RUN      ] SndFileAudioFileReaderTest.shouldReportErrorIfNotAWavFile
/build/source/test/SndFileAudioFileReaderTest.cpp:316: Failure
Value of: error.str()
Expected: is equal to "Failed to read file: ../test/data/test_file_stereo.mp3\nFile contains data in an unknown format.\n"
  Actual: "Failed to read file: ../test/data/test_file_stereo.mp3\nFormat not recognised.\n"
[  FAILED  ] SndFileAudioFileReaderTest.shouldReportErrorIfNotAWavFile (0 ms)
[----------] 10 tests from SndFileAudioFileReaderTest (5 ms total)

@edbentley
Copy link
Contributor Author

@edbentley edbentley commented Dec 2, 2020

@SuperSandro2000 How are you running the tests? When I run nix-build -A audiowaveform it shows as passed to me?

Running tests...
/nix/store/z7qvx6wbvmjvs767g06h03pkzr5aqn6i-cmake-3.18.2/bin/ctest --force-new-ctest-process
Test project /private/var/folders/bh/4nbf2dn14wn3ztnrbrqn11l80000gn/T/nix-build-audiowaveform-1.4.2.drv-0/source/build
    Start 1: audiowaveform_tests
1/1 Test #1: audiowaveform_tests ..............   Passed    6.03 sec

100% tests passed, 0 tests failed out of 1

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 3, 2020

Result of nixpkgs-review pr 101947 run on x86_64-linux 1

1 package failed to build:
  • audiowaveform

Failed test

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 3, 2020

I run nixpkgs-review pr 101947.

@edbentley
Copy link
Contributor Author

@edbentley edbentley commented Dec 8, 2020

Thanks, reproduced locally now. So the failing test is the error message should say "File contains data in an unknown format" but instead says "Format not recognised"...

I'm not sure where that error originates from but I don't see it mentioned in the codebase, so perhaps a dependency. I'm not an original contributor to audiowaveform so I wouldn't know where to start on correcting this test. If the tests can be disabled I can progress, otherwise I think this is as far as I can reasonably get here on my own.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 9, 2020

If the tests can be disabled I can progress, otherwise I think this is as far as I can reasonably get here on my own.

Yeah, you can just disable the tests or preferable the one test.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 9, 2020

Result of nixpkgs-review pr 101947 run on x86_64-darwin 1

1 package failed to build:
  • audiowaveform

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 9, 2020

Result of nixpkgs-review pr 101947 run on x86_64-linux 1

1 package failed to build:
  • audiowaveform
/build/source/test/SndFileAudioFileReaderTest.cpp:316: Failure
Value of: error.str()
Expected: is equal to "Failed to read file: ../test/data/test_file_stereo.mp3\nFile contains data in an unknown format.\n"
  Actual: "Failed to read file: ../test/data/test_file_stereo.mp3\nFormat not recognised.\n"
  [  FAILED  ] SndFileAudioFileReaderTest.shouldReportErrorIfNotAWavFile (0 ms)

@edbentley
Copy link
Contributor Author

@edbentley edbentley commented Dec 9, 2020

Tests have been disabled (added a comment on why) and I've squashed the commits.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 11, 2020

Result of nixpkgs-review pr 101947 run on x86_64-darwin 1

1 package built:
  • audiowaveform

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 11, 2020

Result of nixpkgs-review pr 101947 run on x86_64-linux 1

1 package built:
  • audiowaveform

@SuperSandro2000 SuperSandro2000 merged commit d33fb82 into NixOS:master Dec 11, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants