Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.tmdb3: disable on python3 #101951

Merged
merged 1 commit into from Nov 26, 2020

Conversation

@IvarWithoutBones
Copy link
Contributor

@IvarWithoutBones IvarWithoutBones commented Oct 28, 2020

Motivation for this change

Wanted to use this library, and noticed it didn't work on python3.

Not sure if we should keep the library around at all, as python2 has been deprecated for a while now. For now I've simply disabled it on python3.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 28, 2020

@FRidh I'm fine with removing it.

@omasanori
Copy link
Contributor

@omasanori omasanori commented Oct 28, 2020

Result of nixpkgs-review pr 101951 1

1 package built:
  • python27Packages.tmdb3

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 26, 2020

Result of nixpkgs-review pr 101951 run on x86_64-linux 1

1 package built:
  • python27Packages.tmdb3

@SuperSandro2000 SuperSandro2000 merged commit 60efefa into NixOS:master Nov 26, 2020
17 checks passed
@IvarWithoutBones IvarWithoutBones deleted the disable-tmdb3-py3 branch Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants