Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zsh-powerlevel10k: pin gitstatus version #101952

Merged
merged 1 commit into from Oct 28, 2020
Merged

zsh-powerlevel10k: pin gitstatus version #101952

merged 1 commit into from Oct 28, 2020

Conversation

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 28, 2020

Motivation for this change

The required gitstatus version compatible with zsh-powerlevel10k has
been pinned, as even though it is written by the same author, gitstatus
has received updates which are not yet compatible with zsh-p10k.

Fixes: #101946

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
The required gitstatus version compatible with zsh-powerlevel10k has
been pinned, as even though it is written by the same author, gitstatus
has received updates which are not yet compatible with zsh-p10k.

Fixes: NixOS#101946
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 28, 2020

Result of nixpkgs-review pr 101952 1 run on x86_64-darwin

1 package built:
  • zsh-powerlevel10k

@mweinelt
Copy link
Member Author

@mweinelt mweinelt commented Oct 28, 2020

flokli
flokli approved these changes Oct 28, 2020
Copy link
Contributor

@flokli flokli left a comment

confirmed this fixes it for me. Thanks!

@flokli flokli merged commit 4a64cdd into NixOS:master Oct 28, 2020
19 checks passed
@mweinelt mweinelt deleted the p10k branch Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants