Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.pysmb: add pythonImportsCheck #101953

Merged
merged 1 commit into from Oct 28, 2020
Merged

Conversation

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 28, 2020

Motivation for this change

Create more confidence in automated updates: #101918

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@mweinelt mweinelt requested review from FRidh and jonringer as code owners Oct 28, 2020
Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 101953 1

3 packages built:
  • python27Packages.pysmb
  • python37Packages.pysmb
  • python38Packages.pysmb

@jonringer jonringer merged commit d05139b into NixOS:master Oct 28, 2020
2 of 3 checks passed
@mweinelt mweinelt deleted the pysmb branch Oct 28, 2020
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 28, 2020

Result of nixpkgs-review pr 101953 1 run on x86_64-darwin

3 packages built:
  • python27Packages.pysmb
  • python37Packages.pysmb
  • python38Packages.pysmb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants