Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildkite-agent: 3.17.0 -> 3.25.0, use buildGoModule, add darwin to platforms #101954

Merged
merged 1 commit into from Oct 28, 2020

Conversation

@onsails
Copy link
Contributor

@onsails onsails commented Oct 28, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@onsails onsails force-pushed the buildkite-agent branch from cefcd70 to b7955cb Oct 28, 2020
@onsails
Copy link
Contributor Author

@onsails onsails commented Oct 28, 2020

Result of nixpkgs-review pr 101954 1

1 package built:
  • buildkite-agent

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 28, 2020

Result of nixpkgs-review pr 101954 1 run on x86_64-darwin

1 package built:
  • buildkite-agent (buildkite-agent3)

@zimbatm zimbatm merged commit 0d41c9a into NixOS:master Oct 28, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants