Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hass nabucasa.0.37.1 #101958

Merged
merged 3 commits into from Oct 28, 2020
Merged

Conversation

Scriptkiddi
Copy link
Contributor

Motivation for this change

upgrade hass-nabucasa and deps

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see multiple disabled test cases which have had its issues fixed. Please reenable them.

@Scriptkiddi
Copy link
Contributor Author

I see multiple disabled test cases which have had its issues fixed. Please reenable them.

hey I can only find one, and that one is still needed because the issue is closed but not fixed in that 3.2.0 release

@mweinelt
Copy link
Member

@Scriptkiddi
Copy link
Contributor Author

the test to short issue has been closed, but the test still requires ecdsa<0.15 which we dont have in nixpkgs since its 0.15

@mweinelt
Copy link
Member

mweinelt commented Oct 28, 2020

Yeah, so the idea is that we pin an earlier version, like 0.14.1, locally in the package, to make it work, since the package apparently isn't compatible with newer ecdsa versions.

On second thought, let's not do that. But please enable the hass-nabucasa tests.

@Scriptkiddi
Copy link
Contributor Author

asynctest is still broken on python 3.8 as far as i read this issue Martiusweb/asynctest#132
so enabling it would result in failing tests?

@Scriptkiddi
Copy link
Contributor Author

Scriptkiddi commented Oct 28, 2020

done enabled tests for python 3.8

Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mweinelt mweinelt merged commit 7bbbc71 into NixOS:master Oct 28, 2020
@dasJ dasJ deleted the hass-nabucasa.0.37.1 branch October 15, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants