Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aptly: 1.3.0 -> 1.4.0 #101959

Merged
merged 1 commit into from Oct 28, 2020
Merged

aptly: 1.3.0 -> 1.4.0 #101959

merged 1 commit into from Oct 28, 2020

Conversation

@flokli
Copy link
Contributor

@flokli flokli commented Oct 28, 2020

Motivation for this change

https://github.com/aptly-dev/aptly/releases/tag/v1.4.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@flokli flokli requested review from mweinelt and fadenb Oct 28, 2020
fadenb
fadenb approved these changes Oct 28, 2020
@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 28, 2020

Result of nixpkgs-review pr 101959 1

1 package built:
  • aptly

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 28, 2020

I can see usage, but I have no inclination to test this any further.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 28, 2020

Result of nixpkgs-review pr 101959 1 run on x86_64-darwin

1 package built:
  • aptly

@flokli flokli merged commit e32ca0f into NixOS:master Oct 28, 2020
19 of 20 checks passed
@flokli flokli deleted the aptly140 branch Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants