Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libass 0.14.0 -> 0.15.0 #101965

Closed
wants to merge 1 commit into from
Closed

libass 0.14.0 -> 0.15.0 #101965

wants to merge 1 commit into from

Conversation

@cheriimoya
Copy link
Contributor

@cheriimoya cheriimoya commented Oct 28, 2020

Motivation for this change

Build ffmpeg with newer libass

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ajs124

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 28, 2020

Please retarget this pull request against the staging branch.

@cheriimoya
Copy link
Contributor Author

@cheriimoya cheriimoya commented Oct 28, 2020

done so here #101983 @mweinelt

@cheriimoya cheriimoya closed this Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants