Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildFHSUserEnvBubblewrap: fix whitespace with root directories #101967

Merged
merged 1 commit into from Oct 31, 2020

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 28, 2020

Motivation for this change

closes #101942

I tried doing the same to the ro_mounts, but for some reason the entire array was getting escaped in a ' .. ', which was causing issues.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@worldofpeace worldofpeace left a comment

This commit doesn't change anything in bubblewrap but the userenv builder used by steam?
Should change the attribute

@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Oct 28, 2020

This commit doesn't change anything in bubblewrap but the userenv builder used by steam?
Should change the attribute

This fixes the issue when root directories contain whitespace. If you look at the related issue, the directory '/with space', would be passed as --bind /with space /with space to the bwrap command, but it is now correctly passed as --bind '/with space' '/with space'

steam is just one consumer, there's many other packages as well

@jonringer jonringer force-pushed the fix-bubble-whitespace branch from ad7b990 to ec74da2 Oct 28, 2020
@jonringer jonringer changed the title bubblewrap: fix whitespace with root directories buildFHSUserEnvBubblewrap: fix whitespace with root directories Oct 28, 2020
@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Oct 28, 2020

if you were referring to the commit message pointing to the application, I changed it to the more correct buildFHSUserEnvBubblewrap

@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Oct 28, 2020

if you were referring to the commit message pointing to the application, I changed it to the more correct buildFHSUserEnvBubblewrap

Yep, that's what I meant.

@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Oct 31, 2020

anyway, able to run steam from this

@jonringer jonringer merged commit ec38df8 into NixOS:master Oct 31, 2020
17 checks passed
@jonringer jonringer deleted the fix-bubble-whitespace branch Oct 31, 2020
Atemu added a commit to Atemu/nixpkgs that referenced this issue Nov 22, 2020
Generally a cleaner way of doing it and prevents issues with spaces in paths

Used to fix NixOS#97234 but NixOS#101967 already didt this with a smaller scope
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants