Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home-assistant: 0.116.4 -> 0.117.0 (+ additional package updates) #101968

Merged
merged 7 commits into from Oct 29, 2020

Conversation

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 28, 2020

Motivation for this change

New upstream release. Also update and clean up dependencies.

https://github.com/home-assistant/core/releases

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 28, 2020

@GrahamcOfBorg test home-assistant

version = "0.16.1";
disabled = pythonOlder "3.6";

Comment on lines +21 to 23

This comment has been minimized.

@jonringer

jonringer Oct 28, 2020
Contributor

looks like a regression:

builder for '/nix/store/667gj5w9jcysm7pad0b4lma5hv4zkggf-python3.7-asgi-csrf-0.7.drv' failed with exit code 2; last 10 log lines:
  ImportError while importing test module '/build/source/test_asgi_csrf.py'.
  Hint: make sure your test modules/packages have valid Python names.
  Traceback:
  test_asgi_csrf.py:7: in <module>
      from httpx._content_streams import MultipartStream
  E   ModuleNotFoundError: No module named 'httpx._content_streams'
  =========================== short test summary info ============================
  ERROR test_asgi_csrf.py
  !!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
  =============================== 1 error in 0.15s ===============================
cannot build derivation '/nix/store/hda4799m3wcb5mfazk2x1s77i0v8qykr-python3.7-datasette-0.46.drv': 1 dependencies couldn't be built

This comment has been minimized.

@mweinelt

mweinelt Oct 28, 2020
Author Member

Probably related to encode/httpx@354c4ca.

This comment has been minimized.

@mweinelt

mweinelt Oct 28, 2020
Author Member

Reported in simonw/asgi-csrf#18.

This comment has been minimized.

@jonringer

jonringer Oct 29, 2020
Contributor

looks like they imported a private module... so shame on them

This comment has been minimized.

@jonringer

jonringer Oct 29, 2020
Contributor

maybe just disable that test?

Doesn't look like it's failing on anything exported by the module

This comment has been minimized.

@mweinelt

mweinelt Oct 29, 2020
Author Member

Disabled the tests on asgi-csrf and bumped the package to the latest version for good measure.

@mweinelt mweinelt mentioned this pull request Oct 28, 2020
4 of 10 tasks
@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 29, 2020

everything else passes:

https://github.com/NixOS/nixpkgs/pull/101968
4 packages failed to build:
datasette python37Packages.asgi-csrf python37Packages.datasette python38Packages.asgi-csrf

11 packages built:
google-music-scripts home-assistant python27Packages.spotipy python37Packages.google-music python37Packages.httpcore python37Packages.httpx python37Packages.spotipy python38Packages.google-music python38Packages.httpcore python38Packages.httpx python38Packages.spotipy
mweinelt added 2 commits Oct 29, 2020
The packages tests import a private module from httpx, that does not
exist anymore in newer versions.
@mweinelt
Copy link
Member Author

@mweinelt mweinelt commented Oct 29, 2020

Result of nixpkgs-review pr 101968 1

15 packages built:
  • datasette (python38Packages.datasette)
  • google-music-scripts
  • home-assistant
  • python27Packages.spotipy
  • python37Packages.asgi-csrf
  • python37Packages.datasette
  • python37Packages.google-music
  • python37Packages.httpcore
  • python37Packages.httpx
  • python37Packages.spotipy
  • python38Packages.asgi-csrf
  • python38Packages.google-music
  • python38Packages.httpcore
  • python38Packages.httpx
  • python38Packages.spotipy
Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 101968 1

15 packages built:
  • datasette (python38Packages.datasette)
  • google-music-scripts
  • home-assistant
  • python27Packages.spotipy
  • python37Packages.asgi-csrf
  • python37Packages.datasette
  • python37Packages.google-music
  • python37Packages.httpcore
  • python37Packages.httpx
  • python37Packages.spotipy
  • python38Packages.asgi-csrf
  • python38Packages.google-music
  • python38Packages.httpcore
  • python38Packages.httpx
  • python38Packages.spotipy

@jonringer jonringer merged commit 90a47ba into NixOS:master Oct 29, 2020
14 of 16 checks passed
14 of 16 checks passed
@github-actions
tests tests
Details
@github-actions
action action
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4cc93dc"; rev="4cc93dc57babbb8fc10a0ab8766b696ed60dc5b9"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4cc93dc"; rev="4cc93dc57babbb8fc10a0ab8766b696ed60dc5b9"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4cc93dc"; rev="4cc93dc57babbb8fc10a0ab8766b696ed60dc5b9"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4cc93dc"; rev="4cc93dc57babbb8fc10a0ab8766b696ed60dc5b9"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4cc93dc"; rev="4cc93dc57babbb8fc10a0ab8766b696ed60dc5b9"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4cc93dc"; rev="4cc93dc57babbb8fc10a0ab8766b696ed60dc5b9"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4cc93dc"; rev="4cc93dc57babbb8fc10a0ab8766b696ed60dc5b9"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@mweinelt mweinelt deleted the mweinelt:home-assistant branch Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants