Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tmux-resurrect and tmux-continuum #101971

Merged
merged 3 commits into from Nov 2, 2020
Merged

update tmux-resurrect and tmux-continuum #101971

merged 3 commits into from Nov 2, 2020

Conversation

@RonanMacF
Copy link
Contributor

@RonanMacF RonanMacF commented Oct 28, 2020

Motivation for this change

The plugins seemed a bit outdated so I have updated these two.

Things done

ran nix-prefetch-url with in the repo and updated the sha256. Updated rev with the commit ID of the most recent commit in the respective repor

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@timstott timstott left a comment

Thanks for your contribution 🙇, I have added several comments I hope we can address.

Also could we split each plugin update into its own commits with the template message below (in accordance with CONTRIBUTING.md):

tmuxPlugins.continuum: unstable-2018-02-23 -> xxx

pkgs/misc/tmux-plugins/default.nix Show resolved Hide resolved
pkgs/misc/tmux-plugins/default.nix Show resolved Hide resolved
pkgs/misc/tmux-plugins/default.nix Show resolved Hide resolved
pkgs/misc/tmux-plugins/default.nix Outdated Show resolved Hide resolved
pkgs/misc/tmux-plugins/default.nix Outdated Show resolved Hide resolved
pkgs/misc/tmux-plugins/default.nix Outdated Show resolved Hide resolved
@timstott
Copy link
Contributor

@timstott timstott commented Oct 30, 2020

This is looking better everyday @RonanMacF. Today we need to fix the sha256 for both plugins are they are invalid.

hash mismatch in fixed-output derivation '/nix/store/68jp895j4yxw94jyj0hvbvbv41qs9w59-source':
  wanted: sha256:1z4zx15y0lbkrjapzszg8mhb86i5p3ark71vsl3a3pwb7cx8c3fa
  got:    sha256:1glwa89bv2r92qz579a49prk3jf612cpd5hw46j4wfb35xhnj3ab
hash mismatch in fixed-output derivation '/nix/store/a75px1hp4y1h3aagcw0c03s9grjkamd9-source':
  wanted: sha256:1bh59axhk7ixvdbl676haw5zp697m3008381hj9zv0c9snyffphf
  got:    sha256:0a96drkx1kpadkbxabcnvb542p75xdh2dbizvlq2lac5ldpb4hmx
cannot build derivation '/nix/store/s3cij2kdl179c9267i2h7x2vlpayqkh1-tmuxplugin-resurrect-unstable-2020-09-18.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/kp0mi5kcjmcnlbcw87qdsba2xaplv2hg-tmuxplugin-continuum-unstable-2020-10-16.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/bgjqi89dmsq1ziki41av5njzgsk4ny9f-env.drv': 2 dependencies couldn't be built
[0 built (2 failed)]
error: build of '/nix/store/bgjqi89dmsq1ziki41av5njzgsk4ny9f-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/101971
2 packages failed to build:
tmuxPlugins.continuum tmuxPlugins.resurrect

You can obtain the sha256 for GitHub repos with the following command:

nix-shell -p nix-prefetch-github --command 'nix-prefetch-github tmux-plugins tmux-continuum --rev 26eb5ffce0b559d682b9f98c8d4b6c370ecb639b'

I would also encourage you review the PR locally with nix-review pr 101971

@RonanMacF
Copy link
Contributor Author

@RonanMacF RonanMacF commented Nov 1, 2020

Result of nixpkgs-review pr 101971 1

2 packages built:
  • tmuxPlugins.continuum
  • tmuxPlugins.resurrect

@RonanMacF
Copy link
Contributor Author

@RonanMacF RonanMacF commented Nov 1, 2020

This is looking better everyday @RonanMacF. Today we need to fix the sha256 for both plugins are they are invalid.

hash mismatch in fixed-output derivation '/nix/store/68jp895j4yxw94jyj0hvbvbv41qs9w59-source':
  wanted: sha256:1z4zx15y0lbkrjapzszg8mhb86i5p3ark71vsl3a3pwb7cx8c3fa
  got:    sha256:1glwa89bv2r92qz579a49prk3jf612cpd5hw46j4wfb35xhnj3ab
hash mismatch in fixed-output derivation '/nix/store/a75px1hp4y1h3aagcw0c03s9grjkamd9-source':
  wanted: sha256:1bh59axhk7ixvdbl676haw5zp697m3008381hj9zv0c9snyffphf
  got:    sha256:0a96drkx1kpadkbxabcnvb542p75xdh2dbizvlq2lac5ldpb4hmx
cannot build derivation '/nix/store/s3cij2kdl179c9267i2h7x2vlpayqkh1-tmuxplugin-resurrect-unstable-2020-09-18.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/kp0mi5kcjmcnlbcw87qdsba2xaplv2hg-tmuxplugin-continuum-unstable-2020-10-16.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/bgjqi89dmsq1ziki41av5njzgsk4ny9f-env.drv': 2 dependencies couldn't be built
[0 built (2 failed)]
error: build of '/nix/store/bgjqi89dmsq1ziki41av5njzgsk4ny9f-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/101971
2 packages failed to build:
tmuxPlugins.continuum tmuxPlugins.resurrect

You can obtain the sha256 for GitHub repos with the following command:

nix-shell -p nix-prefetch-github --command 'nix-prefetch-github tmux-plugins tmux-continuum --rev 26eb5ffce0b559d682b9f98c8d4b6c370ecb639b'

I would also encourage you review the PR locally with nix-review pr 101971

All done, sha update and have posted the result of nix-review.

Copy link
Contributor

@timstott timstott left a comment

Excellent! Thanks @RonanMacF

Copy link
Member

@Infinisil Infinisil left a comment

Great review @timstott and nice PR @RonanMacF, looking good!

@Infinisil Infinisil merged commit 93fc868 into NixOS:master Nov 2, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants