Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #101058 coq: propagate and install ocaml and findlib #101972

Merged
merged 1 commit into from Oct 31, 2020

Conversation

@vbgl
Copy link
Contributor

@vbgl vbgl commented Oct 28, 2020

This reverts commit 5d0e2de.

Motivation for this change

#101058 (comment)

cc @Zimmi48 @palmskog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@grahamc grahamc changed the title Revert #101058 Revert #101058 coq: propagate and install ocaml and findlib Oct 28, 2020
@Zimmi48
Copy link
Member

@Zimmi48 Zimmi48 commented Oct 28, 2020

That's a fair use case. This will have to be reverted as well in the Coq repository.

@ofborg ofborg bot requested review from thoughtpolice, roconnor and Zimmi48 Oct 28, 2020
@vbgl vbgl merged commit 8cab21b into NixOS:master Oct 31, 2020
17 checks passed
@vbgl vbgl deleted the coq-dont-propagate-ocaml branch Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants