Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staging] libass 0.14.0 -> 0.15.0 #101983

Merged
merged 1 commit into from Nov 5, 2020
Merged

[staging] libass 0.14.0 -> 0.15.0 #101983

merged 1 commit into from Nov 5, 2020

Conversation

@cheriimoya
Copy link
Contributor

@cheriimoya cheriimoya commented Oct 28, 2020

Motivation for this change

Build ffmpeg with newer libass

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@cheriimoya cheriimoya mentioned this pull request Oct 28, 2020
10 tasks
@mweinelt mweinelt changed the title libass 0.14.0 -> 0.15.0 [staging] libass 0.14.0 -> 0.15.0 Oct 28, 2020
@ofborg ofborg bot requested a review from codyopel Oct 28, 2020
@mweinelt
Copy link
Member

@mweinelt mweinelt commented Nov 4, 2020

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Nov 4, 2020

https://github.com/libass/libass/releases/tag/0.15.0

Require HarfBuzz unconditionally to ensure good shaping for complex scripts

I think that should be addressed in this pull request.

@cheriimoya
Copy link
Contributor Author

@cheriimoya cheriimoya commented Nov 5, 2020

i hope that's what you meant @mweinelt, good point :)

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Nov 5, 2020

The change is fine, but please squash it into the update commit and explain why the change became necessary.

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Nov 5, 2020

That commit is still missing the explanation for why harfbuzz isn't optional anymore.

@cheriimoya
Copy link
Contributor Author

@cheriimoya cheriimoya commented Nov 5, 2020

The initial motivation for this change was the faster subtitle rendering that libass 0.15.0 provides compared to version 0.14.0.
In addition to the initial motivation, as you mentioned, there is #102801 now which should be fixed by bumping libass to the current release.

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Nov 5, 2020

The why should really go into the commit message. Like so:

libass: 0.14.0 -> 0.15.0

Harfbuzz is now being required unconditionally.

Fixes: CVE-2020-26682

You are also missing a colon after the attribute.

Harfbuzz is now being required unconditionally as per
https://github.com/libass/libass/releases/tag/0.15.0

Fixes: CVE-2020-26682
@cheriimoya
Copy link
Contributor Author

@cheriimoya cheriimoya commented Nov 5, 2020

my bad, completely misunderstood you @mweinelt 👀

@mweinelt mweinelt merged commit 372f32f into NixOS:staging Nov 5, 2020
17 of 19 checks passed
@cheriimoya cheriimoya deleted the libass branch Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants