Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monero: 0.17.1.0 -> 0.17.1.1 #101985

Merged
merged 2 commits into from Oct 29, 2020
Merged

monero: 0.17.1.0 -> 0.17.1.1 #101985

merged 2 commits into from Oct 29, 2020

Conversation

@rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Oct 29, 2020

Motivation for this change

Important bugfix

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@rnhmjoj rnhmjoj requested a review from mmahut as a code owner Oct 29, 2020
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 29, 2020

Can you fix the title and commit messages?

monero: 0.17.1.1 -> 0.17.1.1 => monero: 0.17.1.0 -> 0.17.1.1

@rnhmjoj rnhmjoj force-pushed the rnhmjoj:monero branch from d7968a0 to 79a81f8 Oct 29, 2020
@rnhmjoj rnhmjoj changed the title monero: 0.17.1.1 -> 0.17.1.1 monero: 0.17.1.0 -> 0.17.1.1 Oct 29, 2020
@rnhmjoj
Copy link
Contributor Author

@rnhmjoj rnhmjoj commented Oct 29, 2020

Done, thank you.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 29, 2020

Result of nixpkgs-review pr 101985 run on x86_64-darwin 1

1 package built:
  • monero
@rnhmjoj rnhmjoj merged commit df6068e into NixOS:master Oct 29, 2020
19 of 20 checks passed
19 of 20 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@ofborg
monero, monero-gui, monero-gui.passthru.tests, monero.passthru.tests on x86_64-darwin
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="79a81f8"; rev="79a81f81aa5d5f34e001bbee62e639ed02b5c2d3"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="79a81f8"; rev="79a81f81aa5d5f34e001bbee62e639ed02b5c2d3"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="79a81f8"; rev="79a81f81aa5d5f34e001bbee62e639ed02b5c2d3"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="79a81f8"; rev="79a81f81aa5d5f34e001bbee62e639ed02b5c2d3"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="79a81f8"; rev="79a81f81aa5d5f34e001bbee62e639ed02b5c2d3"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="79a81f8"; rev="79a81f81aa5d5f34e001bbee62e639ed02b5c2d3"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="79a81f8"; rev="79a81f81aa5d5f34e001bbee62e639ed02b5c2d3"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg
monero, monero-gui, monero-gui.passthru.tests, monero.passthru.tests on aarch64-linux Success
Details
@ofborg
monero, monero-gui, monero-gui.passthru.tests, monero.passthru.tests on x86_64-linux Success
Details
@rnhmjoj
Copy link
Contributor Author

@rnhmjoj rnhmjoj commented Oct 29, 2020

Backported to 20.09: 47122ce b3bf6a4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants