Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.base64: 3.2.0 → 3.4.0 #101995

Merged
merged 6 commits into from Oct 30, 2020
Merged

ocamlPackages.base64: 3.2.0 → 3.4.0 #101995

merged 6 commits into from Oct 30, 2020

Conversation

@vbgl
Copy link
Contributor

@vbgl vbgl commented Oct 29, 2020

Motivation for this change

Use Dune 2.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 29, 2020

Result of nixpkgs-review pr 101995 run on x86_64-linux 1

6 packages built:
  • dune-release
  • jackline
  • libbap
  • python27Packages.bap
  • python37Packages.bap
  • python38Packages.bap
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 29, 2020

Result of nixpkgs-review pr 101995 run on x86_64-darwin 1

1 package failed to build:
  • dune-release
5 packages built:
  • jackline
  • libbap
  • python27Packages.bap
  • python37Packages.bap
  • python38Packages.bap

dune-release fails cause the sandbox on Darwin is incomplete and it fails to bind to a socket.

builder for '/nix/store/35wa4ax1k5bcb7w96bqvv3iyxc0x6p8i-ocaml4.10.0-curly-unstable-2019-11-14.drv' failed with exit code 1; last 10 log lines:                                               ld: warning: building for macOS, but linking in object file (/nix/store/87fglmq38kx7f005y2hlpxyf1yrwvkn0-ocaml4.10.0-x509-0.11.2/lib/ocaml/4.10.0/site-lib/x509/x509.a(x509__Validation.o)) built for free standing                                                                                                                                                                     ld: warning: building for macOS, but linking in object file (/nix/store/87fglmq38kx7f005y2hlpxyf1yrwvkn0-ocaml4.10.0-x509-0.11.2/lib/ocaml/4.10.0/site-lib/x509/x509.a(x509.o)) built for free standing
  ld: warning: building for macOS, but linking in object file (/nix/store/a4wz30jdw70sqmgwddpwdkhxgbhgkffh-ocaml4.10.0-tls-0.12.5/lib/ocaml/4.10.0/site-lib/tls/lwt/tls_lwt.a(x509_lwt.o)) built for free standing
  ld: warning: building for macOS, but linking in object file (/nix/store/l99lgllrq9xqyi5bmdvfxk1c6bhnd6fl-ocaml4.10.0-zarith-1.10/lib/ocaml/4.10.0/site-lib/zarith/zarith.a(z.o)) built for free standing
    test_curly alias test/runtest (exit 2)
  (cd _build/default/test && ./test_curly.exe)
  Fatal error: exception Unix.Unix_error(Unix.EPERM, "bind", "")
  Testing curly.
  This run has ID `9F44F8A7-4CCA-4228-9E0A-F92013E0243C`.
  Done: 31/33 (jobs: 1)
cannot build derivation '/nix/store/6kai2h1s8f0bnf742dlpli9sdrnqzrwm-ocaml4.10.0-dune-release-1.4.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/sa34bi15136p7n33wmag4j3k0wj375cx-env.drv': 1 dependencies couldn't be built
@vbgl
Copy link
Contributor Author

@vbgl vbgl commented Oct 29, 2020

Thanks for your careful testing!

The failure on macOS seems unrelated to this PR.

Nonetheless, should tests of curly be disabled on that platform?

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 29, 2020

The failure on macOS seems unrelated to this PR.

Nonetheless, should tests of curly be disabled on that platform?

I don't know if it is curly directly or the test before it. I think it fails because of the sandbox. I think those tests should be disabled on darwin to make this package sandbox friendly.

@vbgl
Copy link
Contributor Author

@vbgl vbgl commented Oct 29, 2020

I think those tests should be disabled on darwin

OK, let me do this in a different PR

Copy link
Member

@sternenseemann sternenseemann left a comment

LGTM, nixpkgs-review on x86_64 is good

@vbgl vbgl merged commit 5b8a0f0 into NixOS:master Oct 30, 2020
17 checks passed
17 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3dc6e5e"; rev="3dc6e5eed0dc7450b18f67bea41d0e496b7dcbb8"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3dc6e5e"; rev="3dc6e5eed0dc7450b18f67bea41d0e496b7dcbb8"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3dc6e5e"; rev="3dc6e5eed0dc7450b18f67bea41d0e496b7dcbb8"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3dc6e5e"; rev="3dc6e5eed0dc7450b18f67bea41d0e496b7dcbb8"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3dc6e5e"; rev="3dc6e5eed0dc7450b18f67bea41d0e496b7dcbb8"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3dc6e5e"; rev="3dc6e5eed0dc7450b18f67bea41d0e496b7dcbb8"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3dc6e5e"; rev="3dc6e5eed0dc7450b18f67bea41d0e496b7dcbb8"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@vbgl vbgl deleted the vbgl:ocaml-base64-3.4.0 branch Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants