Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CastXML: refactor to avoid python2 dependency #101996

Merged
merged 1 commit into from Oct 29, 2020

Conversation

@braunse
Copy link
Contributor

@braunse braunse commented Oct 29, 2020

Switch pythonPackages.sphinx to python3Packages.sphinx. Should
only affect the build of the man-page.

Motivation for this change

Removing python2 deps: #101964

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Switch pythonPackages.sphinx to python3Packages.sphinx. Should
only affect the build of the man-page.
@teto
Copy link
Contributor

@teto teto commented Oct 29, 2020

5 packages built:
castxml python27Packages.pybindgen python27Packages.pygccxml python37Packages.pygccxml python38Packages.pygccxml

@teto teto merged commit a74a5c9 into NixOS:master Oct 29, 2020
17 checks passed
17 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a86b342"; rev="a86b342203a06dadf09f4f2624b8bf306392041d"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a86b342"; rev="a86b342203a06dadf09f4f2624b8bf306392041d"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a86b342"; rev="a86b342203a06dadf09f4f2624b8bf306392041d"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a86b342"; rev="a86b342203a06dadf09f4f2624b8bf306392041d"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a86b342"; rev="a86b342203a06dadf09f4f2624b8bf306392041d"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a86b342"; rev="a86b342203a06dadf09f4f2624b8bf306392041d"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a86b342"; rev="a86b342203a06dadf09f4f2624b8bf306392041d"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 29, 2020

Result of nixpkgs-review pr 101996 run on x86_64-darwin 1

5 packages built:
  • castxml
  • python27Packages.pybindgen
  • python27Packages.pygccxml
  • python37Packages.pygccxml
  • python38Packages.pygccxml
@braunse braunse deleted the braunse:update-castxml-python2-dep branch Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants