Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins.vim-easyclip: init at 2019-02-18 #101998

Closed
wants to merge 2 commits into from
Closed

vimPlugins.vim-easyclip: init at 2019-02-18 #101998

wants to merge 2 commits into from

Conversation

@Aptrug
Copy link

@Aptrug Aptrug commented Oct 29, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 29, 2020

Result of nixpkgs-review pr 101998 run on x86_64-darwin 1

1 package built:
  • vimPlugins.vim-clap
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 26, 2020

Can you please fix the merge conflict and only commit the new plugin instead of all the updates?

@jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 26, 2020

Can you please fix the merge conflict and only commit the new plugin instead of all the updates?

I believe the script does this automatically, however, it can be dropped before creating the PR

@Aptrug
Copy link
Author

@Aptrug Aptrug commented Nov 27, 2020

The thing is, I cannot merge conflicts since I deleted nixpkgs repository fork after I discovered that I can just install missing Vim plugins with home-manager using something like this:

  neovim = {
    plugins = let customPlugins = {
      vim-easyclip = pkgs.vimUtils.buildVimPlugin {
        pname = "vim-easyclip";
        version = "2019-02-18";
        src = pkgs.fetchFromGitHub {
          owner = "svermeulen";
          repo = "vim-easyclip";
          rev = "f1a3b95463402b30dd1e22dae7d0b6ea858db2df";
          sha256 = "1y308y4czdzj9ppb0pnc8mkdd393wpwpncvki88aphicjzvw4498";
        };
        meta.homepage = "https://github.com/svermeulen/vim-easyclip/";
      };
    }; in
      with pkgs.vimPlugins // customPlugins; [
        vim-easyclip
      ];
  };

So I'm closing this. Sorry for the noise.

@Aptrug Aptrug closed this Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants