Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockbook-frontend: fix&update extraConfig example #102018

Merged
merged 1 commit into from Oct 30, 2020

Conversation

@1000101
Copy link
Member

@1000101 1000101 commented Oct 29, 2020

Motivation for this change

Provide better and correct (missing quotes) example for Bitcoin configuration.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@1000101 1000101 force-pushed the 1000101:blockbook-frontend branch from 2b6dfa6 to 4b8611c Oct 29, 2020
@1000101
Copy link
Member Author

@1000101 1000101 commented Oct 29, 2020

@GrahamcOfBorg test blockbook-frontend

@bhipple bhipple merged commit e007520 into NixOS:master Oct 30, 2020
19 checks passed
19 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4b8611c"; rev="4b8611c959408c12a4ceefa53c43c738a22f1ae5"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4b8611c"; rev="4b8611c959408c12a4ceefa53c43c738a22f1ae5"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4b8611c"; rev="4b8611c959408c12a4ceefa53c43c738a22f1ae5"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4b8611c"; rev="4b8611c959408c12a4ceefa53c43c738a22f1ae5"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4b8611c"; rev="4b8611c959408c12a4ceefa53c43c738a22f1ae5"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4b8611c"; rev="4b8611c959408c12a4ceefa53c43c738a22f1ae5"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4b8611c"; rev="4b8611c959408c12a4ceefa53c43c738a22f1ae5"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg
tests.blockbook-frontend on aarch64-linux Success
Details
@ofborg
tests.blockbook-frontend on x86_64-linux Success
Details
@1000101 1000101 deleted the 1000101:blockbook-frontend branch Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants