Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh-audit: 2.3.0 -> 2.3.1 #102019

Merged
merged 1 commit into from Nov 3, 2020
Merged

ssh-audit: 2.3.0 -> 2.3.1 #102019

merged 1 commit into from Nov 3, 2020

Conversation

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 29, 2020

Motivation for this change

https://github.com/jtesta/ssh-audit/releases/tag/v2.3.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Oct 29, 2020

Result of nixpkgs-review pr 102019 run on x86_64-darwin 1

1 package built:
  • ssh-audit
@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 29, 2020

Reenable the tests please.

@SuperSandro2000 SuperSandro2000 force-pushed the SuperSandro2000:ssh-audit-2.3.1 branch from ce88f9f to 8b0aa74 Oct 30, 2020
@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Oct 30, 2020

Result of nixpkgs-review pr 102019 run on x86_64-darwin 1

1 package built:
  • ssh-audit
@stigtsp
stigtsp approved these changes Nov 3, 2020
Copy link
Member

@stigtsp stigtsp left a comment

LGTM

Built and tested OK on linux x64

Result of nixpkgs-review pr 102019 1

1 package built:
  • ssh-audit
@stigtsp stigtsp merged commit 0825193 into NixOS:master Nov 3, 2020
19 checks passed
19 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8b0aa74"; rev="8b0aa74128f75c1c4702eb1c1d9293694b36af1d"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8b0aa74"; rev="8b0aa74128f75c1c4702eb1c1d9293694b36af1d"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8b0aa74"; rev="8b0aa74128f75c1c4702eb1c1d9293694b36af1d"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8b0aa74"; rev="8b0aa74128f75c1c4702eb1c1d9293694b36af1d"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8b0aa74"; rev="8b0aa74128f75c1c4702eb1c1d9293694b36af1d"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8b0aa74"; rev="8b0aa74128f75c1c4702eb1c1d9293694b36af1d"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8b0aa74"; rev="8b0aa74128f75c1c4702eb1c1d9293694b36af1d"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg
ssh-audit, ssh-audit.passthru.tests on aarch64-linux Success
Details
@ofborg
ssh-audit, ssh-audit.passthru.tests on x86_64-linux Success
Details
@SuperSandro2000 SuperSandro2000 deleted the SuperSandro2000:ssh-audit-2.3.1 branch Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants