Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rmlint: Use Python3 sphinx for docs #102025

Merged
merged 1 commit into from Oct 30, 2020
Merged

Conversation

@braunse
Copy link
Contributor

@braunse braunse commented Oct 29, 2020

Eliminates a python2 dependency.

Motivation for this change

Using python3 sphinx gets rid of a python2 dependency, see #101964.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Closure size unchanged:

/nix/store/5m7lxqd2a9wivgard7r839fgylm1ak1w-rmlint-2.10.1          61062360
/nix/store/9jwrg48l450wmjipw7i6v4igr5ia9lbk-rmlint-2.10.1          61062360
Eliminates a python2 dependency.
@braunse
Copy link
Contributor Author

@braunse braunse commented Oct 29, 2020

Result of nixpkgs-review pr 102025 1

1 package built:
  • rmlint
Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 102025 1

1 package built:
  • rmlint

@jonringer jonringer merged commit c0bcfeb into NixOS:master Oct 30, 2020
19 checks passed
19 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="67c00b7"; rev="67c00b78496a2d819cce66b4ad0b53b0410625c1"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="67c00b7"; rev="67c00b78496a2d819cce66b4ad0b53b0410625c1"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="67c00b7"; rev="67c00b78496a2d819cce66b4ad0b53b0410625c1"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="67c00b7"; rev="67c00b78496a2d819cce66b4ad0b53b0410625c1"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="67c00b7"; rev="67c00b78496a2d819cce66b4ad0b53b0410625c1"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="67c00b7"; rev="67c00b78496a2d819cce66b4ad0b53b0410625c1"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="67c00b7"; rev="67c00b78496a2d819cce66b4ad0b53b0410625c1"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg
rmlint, rmlint.passthru.tests on aarch64-linux Success
Details
@ofborg
rmlint, rmlint.passthru.tests on x86_64-linux Success
Details
@braunse braunse deleted the braunse:patch-rmlint-python2-dep branch Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants