Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fortune-mod: 2.10.0 -> 3.2.0 #102027

Merged
merged 1 commit into from Nov 8, 2020
Merged

fortune-mod: 2.10.0 -> 3.2.0 #102027

merged 1 commit into from Nov 8, 2020

Conversation

@Vonfry
Copy link
Member

@Vonfry Vonfry commented Oct 29, 2020

Motivation for this change

Update and add update script as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 29, 2020

Result of nixpkgs-review pr 102027 run on x86_64-linux 1

2 packages failed to build:
  • gtypist
  • xcowsay
2 packages built:
  • ding
  • fortune

Unrelated to this PR

configuring
configure flags: --disable-dependency-tracking --prefix=/nix/store/xilg2k9kqas8flrff9nfn5cdpcz19wkl-xcowsay-1.5 --enable-dbus
/nix/store/q1zjp9grl4w92qalkdqjs2bj5d0pf8ih-stdenv-linux/setup: ./configure: /bin/sh: bad interpreter: No such file or directory
@Vonfry Vonfry force-pushed the Vonfry:update/fortune-3.2.0 branch 2 times, most recently from da604ec to 7043492 Oct 30, 2020
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 31, 2020

Result of nixpkgs-review pr 102027 run on x86_64-linux 1

4 packages built:
  • ding
  • fortune
  • gtypist
  • xcowsay
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 31, 2020

Result of nixpkgs-review pr 102027 run on x86_64-darwin 1

2 packages built:
  • fortune
  • gtypist
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Oct 31, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/353

@ajs124
ajs124 approved these changes Nov 4, 2020
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Nov 7, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/281

Copy link
Member

@danieldk danieldk left a comment

See the comment on using fetchFromGitHub and making the update script unnecessary.

@Vonfry Vonfry force-pushed the Vonfry:update/fortune-3.2.0 branch 2 times, most recently from aaf9d7f to ab4b325 Nov 8, 2020
@Vonfry Vonfry force-pushed the Vonfry:update/fortune-3.2.0 branch from ab4b325 to 7b117f1 Nov 8, 2020
@Vonfry Vonfry requested a review from danieldk Nov 8, 2020
Copy link
Member

@danieldk danieldk left a comment

LGTM, thanks!

Result of nixpkgs-review pr 102027 1

4 packages built:
  • ding
  • fortune
  • gtypist
  • xcowsay

fortune works as expected.

@danieldk danieldk merged commit 6519e0b into NixOS:master Nov 8, 2020
17 checks passed
17 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7b117f1"; rev="7b117f15b15c512ae857c2cdf00cfac417614dce"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7b117f1"; rev="7b117f15b15c512ae857c2cdf00cfac417614dce"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7b117f1"; rev="7b117f15b15c512ae857c2cdf00cfac417614dce"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7b117f1"; rev="7b117f15b15c512ae857c2cdf00cfac417614dce"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7b117f1"; rev="7b117f15b15c512ae857c2cdf00cfac417614dce"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7b117f1"; rev="7b117f15b15c512ae857c2cdf00cfac417614dce"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7b117f1"; rev="7b117f15b15c512ae857c2cdf00cfac417614dce"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@Vonfry Vonfry deleted the Vonfry:update/fortune-3.2.0 branch Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants