Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gstreamer: needs Xext build input when x11 is enabled #102032

Merged
merged 1 commit into from Oct 29, 2020

Conversation

@paralin
Copy link
Contributor

@paralin paralin commented Oct 29, 2020

Motivation for this change

Fixes #102023

When x11 is enabled, gstreamer-plugins-base requires libXext as a build input.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@nh2
Copy link
Contributor

@nh2 nh2 commented Oct 29, 2020

10.rebuild-linux: 1001-2500 labels

@paralin This needs to PR against staging because it's a mass rebuild, please rebase it and change the target branch using Github's Edit button above.

I've built the PR on top of master, there it builds fine, so beyond that, this is good to merge (rationale in #102023 (comment)).

@paralin paralin changed the base branch from master to staging Oct 29, 2020
@paralin paralin requested review from FRidh, jonringer and mmahut as code owners Oct 29, 2020
Fixes #102023

Signed-off-by: Christian Stewart <christian@paral.in>
@paralin paralin force-pushed the paralin:fix-gstreamer-plugins-base-xext branch from f504240 to 2537e11 Oct 29, 2020
@paralin
Copy link
Contributor Author

@paralin paralin commented Oct 29, 2020

@nh2 Done.

@nh2
nh2 approved these changes Oct 29, 2020
@nh2 nh2 merged commit bc2b206 into NixOS:staging Oct 29, 2020
17 checks passed
17 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2537e11"; rev="2537e1169c7955448bc26f5b1b7aa15773c57ffa"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2537e11"; rev="2537e1169c7955448bc26f5b1b7aa15773c57ffa"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2537e11"; rev="2537e1169c7955448bc26f5b1b7aa15773c57ffa"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2537e11"; rev="2537e1169c7955448bc26f5b1b7aa15773c57ffa"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2537e11"; rev="2537e1169c7955448bc26f5b1b7aa15773c57ffa"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2537e11"; rev="2537e1169c7955448bc26f5b1b7aa15773c57ffa"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2537e11"; rev="2537e1169c7955448bc26f5b1b7aa15773c57ffa"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants