Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

entt: init at 3.5.2 #102036

Merged
merged 1 commit into from Dec 27, 2020
Merged

entt: init at 3.5.2 #102036

merged 1 commit into from Dec 27, 2020

Conversation

@Twey
Copy link
Contributor

@Twey Twey commented Oct 29, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 29, 2020

Result of nixpkgs-review pr 102036 run on x86_64-linux 1

1 package failed to build:
  • entt
-- Check for working CXX compiler: /nix/store/8madhhcxhxlf0rrc5hdsk65l206r3cc6-gcc-wrapper-9.3.0/bin/g++ - broken
CMake Error at /nix/store/r9djcvv9hh6cma006jxlcz3xljz7zck0-cmake-3.18.2/share/cmake-3.18/Modules/CMakeTestCXXCompiler.cmake:59 (message):
  The C++ compiler

    "/nix/store/8madhhcxhxlf0rrc5hdsk65l206r3cc6-gcc-wrapper-9.3.0/bin/g++"

  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: /build/source/build/CMakeFiles/CMakeTmp

    Run Build Command(s):/nix/store/vc851g6wnyyykb5jxgbal3whi5495xia-gnumake-4.3/bin/make cmTC_51798/fast && /nix/store/vc851g6wnyyykb5jxgbal3whi5495xia-gnumake-4.3/bin/make  -f CMakeFiles/cmTC_51798.dir/build.make CMakeFiles/cmTC_51798.dir/build
    make[1]: Entering directory '/build/source/build/CMakeFiles/CMakeTmp'
    make[1]: /bin/sh: No such file or directory
    make[1]: *** [CMakeFiles/cmTC_51798.dir/build.make:84: CMakeFiles/cmTC_51798.dir/testCXXCompiler.cxx.o] Error 127
    make[1]: Leaving directory '/build/source/build/CMakeFiles/CMakeTmp'
    make: *** [Makefile:140: cmTC_51798/fast] Error 2





  CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
  CMakeLists.txt:28 (project)


-- Configuring incomplete, errors occurred!
@Twey
Copy link
Contributor Author

@Twey Twey commented Oct 29, 2020

I don't understand this error. This looks like CMake is generating Makefiles that depend on /bin/sh? /bin/sh isn't mentioned in the CMake of the source.

@Twey Twey force-pushed the Twey:entt-3.5.2 branch from 00efe71 to 34cd247 Oct 29, 2020
@Twey
Copy link
Contributor Author

@Twey Twey commented Oct 29, 2020

(thank you for the suggestions!)

@Flakebi
Copy link
Member

@Flakebi Flakebi commented Oct 30, 2020

Result of nixpkgs-review pr 102036 1

1 package built:
  • entt

Seems to work for me

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 30, 2020

Result of nixpkgs-review pr 102036 run on x86_64-linux 1

1 package built:
  • entt
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@Twey Twey force-pushed the Twey:entt-3.5.2 branch from 34cd247 to 5a17b07 Nov 2, 2020
@Flakebi
Flakebi approved these changes Nov 2, 2020
homepage = "https://github.com/skypjack/entt";
description = "A header-only, tiny and easy to use library for game programming and much more written in modern C++";
maintainers = with maintainers; [ twey ];
license = licenses.mit;

This comment has been minimized.

@SuperSandro2000

SuperSandro2000 Nov 25, 2020
Member

Can you please add platforms.

This comment has been minimized.

@doronbehar

doronbehar Dec 18, 2020
Contributor

No platforms specified means I guess all platforms should be supported.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 27, 2020

Result of nixpkgs-review pr 102036 run on x86_64-linux 1

1 package built:
  • entt
@SuperSandro2000 SuperSandro2000 merged commit c958c1b into NixOS:master Dec 27, 2020
19 checks passed
19 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
entt, entt.passthru.tests on aarch64-linux Success
Details
@ofborg
entt, entt.passthru.tests on x86_64-linux Success
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5a17b07"; rev="5a17b0759e20c66f2d3176cd5df5b93bac357cb4"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5a17b07"; rev="5a17b0759e20c66f2d3176cd5df5b93bac357cb4"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5a17b07"; rev="5a17b0759e20c66f2d3176cd5df5b93bac357cb4"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5a17b07"; rev="5a17b0759e20c66f2d3176cd5df5b93bac357cb4"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5a17b07"; rev="5a17b0759e20c66f2d3176cd5df5b93bac357cb4"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5a17b07"; rev="5a17b0759e20c66f2d3176cd5df5b93bac357cb4"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5a17b07"; rev="5a17b0759e20c66f2d3176cd5df5b93bac357cb4"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants