Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wayland: make reproducible #102038

Merged
merged 1 commit into from Oct 29, 2020
Merged

wayland: make reproducible #102038

merged 1 commit into from Oct 29, 2020

Conversation

@alyssais
Copy link
Member

@alyssais alyssais commented Oct 29, 2020

Upstream MR:
https://gitlab.freedesktop.org/wayland/wayland/-/merge_requests/93

I’m the one responsible for making this package non-reproducible in the first place, since I enabled the documentation in #92128.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 29, 2020

Don't take blame for that. As long as you don't break something on purpose and you help fixing it everything is fine.

@alyssais alyssais force-pushed the alyssais:wayland branch from f737a60 to 76dc59e Oct 29, 2020
Copy link
Member

@grahamc grahamc left a comment

🥳 I of course would prefer upstream make their own IDs consistent, but making it better is always good :D #55421 (comment)

@alyssais alyssais force-pushed the alyssais:wayland branch from 76dc59e to dfe75b9 Oct 29, 2020
@ofborg ofborg bot requested a review from primeos Oct 29, 2020
Copy link
Member

@primeos primeos left a comment

Thanks again :)

@primeos primeos merged commit 350df0f into NixOS:staging Oct 29, 2020
19 of 20 checks passed
19 of 20 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@ofborg
wayland, wayland.passthru.tests on x86_64-darwin
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="dfe75b9"; rev="dfe75b97ca68ddc4a6e5eb000904ecd53432c1fe"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="dfe75b9"; rev="dfe75b97ca68ddc4a6e5eb000904ecd53432c1fe"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="dfe75b9"; rev="dfe75b97ca68ddc4a6e5eb000904ecd53432c1fe"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="dfe75b9"; rev="dfe75b97ca68ddc4a6e5eb000904ecd53432c1fe"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="dfe75b9"; rev="dfe75b97ca68ddc4a6e5eb000904ecd53432c1fe"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="dfe75b9"; rev="dfe75b97ca68ddc4a6e5eb000904ecd53432c1fe"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="dfe75b9"; rev="dfe75b97ca68ddc4a6e5eb000904ecd53432c1fe"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg
wayland, wayland.passthru.tests on aarch64-linux Success
Details
@ofborg
wayland, wayland.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants