Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtypist, xcowsay: Patch shebangs in configure script #102052

Closed
wants to merge 2 commits into from

Conversation

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 29, 2020

Motivation for this change

#102027 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000 SuperSandro2000 changed the title Sandbox gtypist, xcowsay: Patch shebangs in configure script Oct 29, 2020
@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Oct 29, 2020

Result of nixpkgs-review pr 102052 run on x86_64-linux 1

2 packages built:
  • gtypist
  • xcowsay
@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Oct 29, 2020

Result of nixpkgs-review pr 102052 run on x86_64-darwin 1

2 packages built:
  • gtypist
  • xcowsay
@dasJ
dasJ approved these changes Oct 29, 2020
@dasJ dasJ requested a review from ajs124 Oct 29, 2020
@ajs124
Copy link
Member

@ajs124 ajs124 commented Nov 4, 2020

These both seem to build fine for me on master, why is this needed?

@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Nov 6, 2020

These both seem to build fine for me on master, why is this needed?

See motivation.

@SuperSandro2000 SuperSandro2000 deleted the SuperSandro2000:sandbox branch Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants