Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gogs: 0.11.91 -> 0.12.3 #102061

Merged
merged 1 commit into from Nov 29, 2020
Merged

gogs: 0.11.91 -> 0.12.3 #102061

merged 1 commit into from Nov 29, 2020

Conversation

@braunse
Copy link
Contributor

@braunse braunse commented Oct 29, 2020

Motivation for this change

Upstream release: https://github.com/gogs/gogs/releases/tag/v0.12.3
FIxes:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@braunse
Copy link
Contributor Author

@braunse braunse commented Oct 29, 2020

Result of nixpkgs-review pr 102061 1

1 package built:
  • gogs
@braunse
Copy link
Contributor Author

@braunse braunse commented Oct 29, 2020

Closure size comparison:

/nix/store/lffwq0nv4djkbwmxsv0a67z84q2ql8bf-gogs-0.11.91          448391248  # before
/nix/store/4isb92hw8ivgw1s00wj6qsn94wfw1vxb-gogs-0.12.3           444369544 # after
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 29, 2020

Result of nixpkgs-review pr 102061 run on x86_64-darwin 1

1 package built:
  • gogs
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 25, 2020

Result of nixpkgs-review pr 102061 run on x86_64-linux 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
1 package built:
  • gogs
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 26, 2020

Please squash the commits together.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 26, 2020

Result of nixpkgs-review pr 102061 run on x86_64-darwin 1

1 package built:
  • gogs
@braunse braunse force-pushed the braunse:gogs-0-12-3 branch from 9a7fe2b to ebfb9f2 Nov 28, 2020
@braunse braunse force-pushed the braunse:gogs-0-12-3 branch from ebfb9f2 to 5c87a6b Nov 28, 2020
Copy link
Member

@stigtsp stigtsp left a comment

LGTM

Result of nixpkgs-review pr 102061 run on x86_64-linux 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
1 package built:
  • gogs

Tested OK on linux x64:

  • Enabled via service.gogs
  • Setup using service.gogs.useWizard with sqlite3 backend
  • Created repo, pushed commit via http
@stigtsp stigtsp merged commit e2968a0 into NixOS:master Nov 29, 2020
19 checks passed
19 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
gogs, gogs.passthru.tests on aarch64-linux Success
Details
@ofborg
gogs, gogs.passthru.tests on x86_64-linux Success
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5c87a6b"; rev="5c87a6b8ea7ec9a0ed17d2a371bdd03bd6bb993f"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5c87a6b"; rev="5c87a6b8ea7ec9a0ed17d2a371bdd03bd6bb993f"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5c87a6b"; rev="5c87a6b8ea7ec9a0ed17d2a371bdd03bd6bb993f"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5c87a6b"; rev="5c87a6b8ea7ec9a0ed17d2a371bdd03bd6bb993f"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5c87a6b"; rev="5c87a6b8ea7ec9a0ed17d2a371bdd03bd6bb993f"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5c87a6b"; rev="5c87a6b8ea7ec9a0ed17d2a371bdd03bd6bb993f"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5c87a6b"; rev="5c87a6b8ea7ec9a0ed17d2a371bdd03bd6bb993f"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@dotlambda
Copy link
Member

@dotlambda dotlambda commented Feb 1, 2021

Can we backport the update without making a breaking change in the NixOS module?

@dotlambda dotlambda mentioned this pull request Feb 1, 2021
10 tasks
@gebner gebner mentioned this pull request Apr 3, 2021
4 of 10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants