Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-tauri-bundler: init at 0.9.3 #102064

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

@onsails
Copy link
Contributor

@onsails onsails commented Oct 29, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@onsails onsails force-pushed the onsails:cargo-tauri-bundler branch 4 times, most recently from 130a9ea to e88ee3c Oct 29, 2020
@onsails onsails marked this pull request as ready for review Oct 29, 2020
@onsails onsails force-pushed the onsails:cargo-tauri-bundler branch 2 times, most recently from 6b6453a to c550d6b Oct 29, 2020
@onsails onsails force-pushed the onsails:cargo-tauri-bundler branch 2 times, most recently from 86ed8b1 to f76f091 Oct 30, 2020
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 30, 2020

Result of nixpkgs-review pr 102064 run on x86_64-linux 1

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Nov 6, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/dont-link-to-nix-libs/9867/1

onsails = {
email = "andrey@onsails.com";
github = "onsails";
githubId = 107261;

This comment has been minimized.

@SuperSandro2000

SuperSandro2000 Nov 23, 2020
Member

Adding maintainer requires to be put in a separate commit per contributing guide.


cargoSha256 = "f55QXLm4qix52Y624pBypIPgvv0ApdT2XrWFkAK9TKM=";

buildInputs = [ ] ++ lib.optionals stdenv.isDarwin [

This comment has been minimized.

@SuperSandro2000

SuperSandro2000 Nov 23, 2020
Member

Suggested change
buildInputs = [ ] ++ lib.optionals stdenv.isDarwin [
buildInputs = lib.optionals stdenv.isDarwin [
description = ''Cargo subcommand "tauri-bundler": wrap Rust executables in OS-specific app bundles'';
homepage = "https://github.com/tauri-apps/tauri";
license = with licenses; [ mit ];
platforms = platforms.all;

This comment has been minimized.

@SuperSandro2000

SuperSandro2000 Nov 23, 2020
Member

This should not be sit in buildRustPackage .

homepage = "https://github.com/tauri-apps/tauri";
license = with licenses; [ mit ];
platforms = platforms.all;
maintainers = [ maintainers.onsails ];

This comment has been minimized.

@SuperSandro2000

SuperSandro2000 Nov 23, 2020
Member

Suggested change
maintainers = [ maintainers.onsails ];
maintainers = with maintainers; [ onsails ];
@onsails onsails marked this pull request as draft Jan 9, 2021
@onsails onsails force-pushed the onsails:cargo-tauri-bundler branch from 6807c1f to 0793130 Jan 29, 2021
@stale
Copy link

@stale stale bot commented Jul 29, 2021

I marked this as stale due to inactivity. → More info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants